Release deprecated label fix #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 5, 2023 11:49
Before: $ helm package . Successfully packaged chart and saved it to: /.../charts/charts/harvester-network-controller/harvester-network-controller-0.3.2.tgz $ helm upgrade --dry-run -n harvester-system harvester harvester-network-controller-0.3.2.tgz | grep beta\.kubernetes\.io\/os | wc -l 1 After: $ helm package . Successfully packaged chart and saved it to: /.../charts/charts/harvester-network-controller/harvester-network-controller-0.3.2.tgz $ helm upgrade --dry-run -n harvester-system harvester harvester-network-controller-0.3.2.tgz | grep beta\.kubernetes\.io\/os | wc -l 0 Related-to: harvester/harvester#2899 Signed-off-by: Connor Kuehl <connor.kuehl@suse.com> (cherry picked from commit 833cb08)
Related issue: harvester/harvester#2899 Signed-off-by: Connor Kuehl <connor.kuehl@suse.com>
|
cc @yaocw2020 can u PTAL and cutting a new RC version for the network-controller since there are some code changes, thanks. |
bk201
approved these changes
Jun 13, 2023
guangbochen
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: harvester/harvester#2899
Signed-off-by: Connor Kuehl connor.kuehl@suse.com