Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FFM-8688] - Handle accountID as an optional field in the JWT token #157

Merged
merged 3 commits into from
Jul 18, 2023
Merged

[FFM-8688] - Handle accountID as an optional field in the JWT token #157

merged 3 commits into from
Jul 18, 2023

Commits on Jul 18, 2023

  1. [FFM-8688] - Handle accountID as an optional field in the JWT token 

    What
Adding new unit tests + harden the existing JWT parsing code to handle information which may be optional when an ff-proxy is in use.
If the info is not available the header will not be added. Also fixed env header to fall back to UUID when not present.

Why
The proxy doesn’t send accountID in the JWT token on auth, so we should make sure the code handles this correctly without bailing out when a proxy is in use.

Testing
New unit tests written + manual
    @andybharness
    andybharness committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    b5d6730 View commit details
    Browse the repository at this point in the history

  2. rename environment to environmentUuid to make code easier to understand

    @andybharness
    andybharness committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    611a90b View commit details
    Browse the repository at this point in the history

  3. adding some additional test coverage to CfClientTest

    @andybharness
    andybharness committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2b9bf56 View commit details
    Browse the repository at this point in the history