[FFM-8688] - Handle accountID as an optional field in the JWT token #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What Adding new unit tests + harden the existing JWT parsing code to handle information which may be optional when an ff-proxy is in use. If the info is not available the header will not be added. Also fixed env header to fall back to UUID when not present. Why The proxy doesn’t send accountID in the JWT token on auth, so we should make sure the code handles this correctly without bailing out when a proxy is in use. Testing New unit tests written + manual
erdirowlands
approved these changes
Jul 18, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
============================================
- Coverage 60.86% 60.65% -0.22%
- Complexity 356 362 +6
============================================
Files 31 31
Lines 1763 1779 +16
Branches 195 202 +7
============================================
+ Hits 1073 1079 +6
- Misses 540 546 +6
- Partials 150 154 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFM-8688 - Handle accountID as an optional field in the JWT token
What
Adding new unit tests + harden the existing JWT parsing code to handle information which may be optional when an ff-proxy is in use. If the info is not available the header will not be added. Also fixed env header to fall back to UUID when not present.
Why
The proxy doesn’t send accountID in the JWT token on auth, so we should make sure the code handles this correctly without bailing out when a proxy is in use.
Testing
New unit tests written + manual