Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cd relnotes 805xx cds 78504 v2 #3236

Merged
merged 6 commits into from
Sep 11, 2023
Merged

Cd relnotes 805xx cds 78504 v2 #3236

merged 6 commits into from
Sep 11, 2023

Conversation

douglas-j-bothwell
Copy link
Contributor

@douglas-j-bothwell douglas-j-bothwell commented Sep 7, 2023 •
edited
Loading

Harness Developer Pull Request

This note supersedes the original CD 805xx release-notes PR which I had to close due to numerous merge-conflict issues:

#3197

Preview links

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@douglas-j-bothwell douglas-j-bothwell mentioned this pull request Sep 7, 2023
Closed
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@douglas-j-bothwell douglas-j-bothwell added DO NOT MERGE PR is not ready to be merged. peer review Review - PM Needs review from PM labels Sep 7, 2023
@douglas-j-bothwell douglas-j-bothwell self-assigned this Sep 7, 2023
brian-r-fisher
brian-r-fisher previously approved these changes Sep 7, 2023
View reviewed changes
@douglas-j-bothwell @brian-r-fisher
Apply suggestions from code review
19410e5 
BF edits

Co-authored-by: brian-f-harness <brian.fisher@harness.io>
@douglas-j-bothwell @brian-r-fisher
Apply suggestions from code review
d5fe3ee 
BF edits

Co-authored-by: brian-f-harness <brian.fisher@harness.io>
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@deepakbolangady
Copy link
Contributor

The release notes have been peer-reviewed already. Just did some housekeeping in the last two commits. Forcing a merge.

@deepakbolangady deepakbolangady merged commit e4bca4b into main Sep 11, 2023
@deepakbolangady deepakbolangady deleted the cd-relnotes-805xx-cds-78504-v2 branch September 11, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-r-fisher brian-r-fisher brian-r-fisher left review comments

@PrasadRavella PrasadRavella Awaiting requested review from PrasadRavella

Assignees

@douglas-j-bothwell douglas-j-bothwell

Labels
DO NOT MERGE PR is not ready to be merged. Review - PM Needs review from PM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@douglas-j-bothwell @bot-gitexp-user @deepakbolangady @brian-r-fisher