Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cd relnotes 805xx cds 78504 #3197

Closed
wants to merge 13 commits into from
Closed

Cd relnotes 805xx cds 78504 #3197

wants to merge 13 commits into from

Conversation

douglas-j-bothwell
Copy link
Contributor

@douglas-j-bothwell douglas-j-bothwell commented Sep 5, 2023 •
edited
Loading

Harness Developer Pull Request

This PR is closed. See the following for the latest CD 805xx release notes content: #3236

@douglas-j-bothwell douglas-j-bothwell self-assigned this Sep 5, 2023
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@douglas-j-bothwell douglas-j-bothwell added DO NOT MERGE PR is not ready to be merged. peer review Review - PM Needs review from PM labels Sep 6, 2023
michaelcretzman
michaelcretzman previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions.

@douglas-j-bothwell @michaelcretzman
Apply suggestions from code review
6c4b618 
Co-authored-by: Michael Cretzman <58786311+michaelcretzman@users.noreply.github.com>
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

1 similar comment
@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@bot-gitexp-user
Copy link

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app

@douglas-j-bothwell douglas-j-bothwell mentioned this pull request Sep 7, 2023
Merged
@douglas-j-bothwell
Copy link
Contributor Author

I had to close this PR due to numerous merge-conflict issues.

See the following PR for the latest updates: #3236

@douglas-j-bothwell douglas-j-bothwell added wont fix / invalid / duplicate For closed PRs. and removed peer review Review - PM Needs review from PM labels Sep 8, 2023
@ravilach ravilach deleted the cd-relnotes-805xx-cds-78504 branch October 4, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelcretzman michaelcretzman michaelcretzman left review comments

@prasadsatamharness prasadsatamharness Awaiting requested review from prasadsatamharness prasadsatamharness is a code owner

Assignees

@douglas-j-bothwell douglas-j-bothwell

Labels
DO NOT MERGE PR is not ready to be merged. wont fix / invalid / duplicate For closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@douglas-j-bothwell @bot-gitexp-user @michaelcretzman