Skip to content

Fix Vector CANlib treatment of empty app name #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2020
Merged

Fix Vector CANlib treatment of empty app name #814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion can/interfaces/vector/canlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def __init__(
else:
# Assume comma separated string of channels
self.channels = [int(ch.strip()) for ch in channel.split(",")]
self._app_name = app_name.encode() if app_name is not None else ""
self._app_name = app_name.encode() if app_name is not None else b""
self.channel_info = "Application %s: %s" % (
app_name,
", ".join("CAN %d" % (ch + 1) for ch in self.channels),
Expand Down