Fix Vector CANlib treatment of empty app name #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python 2, the str type was used for text and bytes, whereas in Python 3, these are separate and incompatible types. This broke instantiation of a VectorBus when the app_name parameter in __init__ was set to None. This correctly sets it to a bytes object. Fixes hardbyte#796
Merged
Codecov Report
@@ Coverage Diff @@
## develop #814 +/- ##
===========================================
+ Coverage 67.00% 69.71% +2.70%
===========================================
Files 70 70
Lines 6577 6577
===========================================
+ Hits 4407 4585 +178
+ Misses 2170 1992 -178 |
hardbyte
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python 2, the str type was used for text and bytes, whereas in Python
3, these are separate and incompatible types. This broke instantiation
of a VectorBus when the app_name parameter in init was set to None.
This correctly sets it to a bytes object.
Fixes #796