Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing maxParts type in route.d.ts #4501

Closed
edoardo-bluframe opened this issue Apr 18, 2024 · 0 comments · Fixed by #4507
Closed

Missing maxParts type in route.d.ts #4501

edoardo-bluframe opened this issue Apr 18, 2024 · 0 comments · Fixed by #4507
Assignees
Labels
bug Bug or defect
Milestone

Comments

@edoardo-bluframe
Copy link

edoardo-bluframe commented Apr 18, 2024

Runtime

node.js

Runtime version

18+

Module version

21.3.3

Last module version without issue

No response

Used with

No response

Any other relevant information

No response

What are you trying to achieve or the steps to reproduce?

Set maxParts in multipart payload

payload: {
      // 2MB
      maxBytes: 2097152,
      maxParts: 2,
      multipart: {
        output: "stream"
      },
      parse: true
    }

What was the result you got?

When we do that we get:

typescript: Object literal may only specify known properties, and 'maxParts' does not exist in type 'RouteOptionsPayload'. [2353]

What result did you expect?

We expect it to work:

This is actually a super easy fix:

maxBytes?: number | undefined;

We just need to add

maxParts?: number | undefined;

In that line 😄

@edoardo-bluframe edoardo-bluframe added the bug Bug or defect label Apr 18, 2024
damusix added a commit to damusix/hapi that referenced this issue Jun 9, 2024
damusix added a commit to damusix/hapi that referenced this issue Jun 10, 2024
damusix added a commit to damusix/hapi that referenced this issue Jun 10, 2024
@Marsup Marsup added this to the 21.3.10 milestone Jun 12, 2024
@Marsup Marsup linked a pull request Jun 12, 2024 that will close this issue
Marsup pushed a commit that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants