fix: 🐛 route payload options missing types#4507
Merged
Marsup merged 3 commits intohapijs:masterfrom Jun 12, 2024
Merged
Conversation
damusix
force-pushed
the
fix/missing-types
branch
from
0b7b1bd to
c8d7e2a
Compare
damusix
force-pushed
the
fix/missing-types
branch
from
c8d7e2a to
8a249d3
Compare
damusix
commented
Jun 10, 2024
| @@ -1,5 +1,6 @@ | |||
| import { types as lab } from '@hapi/lab'; | |||
| import { expect } from '@hapi/code'; | |||
| import * as CatboxMemory from '@hapi/catbox-memory'; | |||
Contributor
Author
There was a problem hiding this comment.
Dependent on hapijs/catbox-memory#90 for tests to pass
Nargonath
approved these changes
Jun 10, 2024
Member
Nargonath
left a comment
Nargonath
left a comment
There was a problem hiding this comment.
Code LGTM. We'll see how the tests looks once the dependent PR is merged and deployed.
kanongil
reviewed
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Fixes #4505 #4501 #4504
Additionally adds missing method cache typings to select cache name and segment name