Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Text API #1718

Merged
merged 6 commits into from
May 8, 2024
Merged

Conversation

ThatGravyBoat
Copy link
Contributor

@ThatGravyBoat ThatGravyBoat commented May 6, 2024

What

This PR adds the Text object which is a file that contains numerous utilities for creating chat components. In addition to this it makes it easier to complete some todos that were related to components. This also cleans up the chat action manager to be a map to action to make sure lookups at O(1) instead of looping through all, it also moves it to the utilities package with the other components utils into a new package chat.

Changelog Technical Details

  • Added Text object that provides various helpers, DSL, and utilities for interaction with chat components. - ThatGravyBoat

@hannibal002 hannibal002 added the Backend A backend pull request that will be merged soon label May 6, 2024
@hannibal002 hannibal002 modified the milestones: Version 0.26, Version 0.25 May 6, 2024
…t-utils

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/data/ChatClickActionManager.kt
#	src/main/java/at/hannibal2/skyhanni/utils/ChatUtils.kt
Copy link

github-actions bot commented May 7, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 7, 2024
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

Conflicts have been resolved! 🎉

@hannibal002 hannibal002 added the Bug Fix Bug fixes label May 7, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont delete/break existing functions in ChatUtils. rather mark them as deprecated and delete them in 1-2 weeks in another pr.

@ThatGravyBoat
Copy link
Contributor Author

Please dont delete/break existing functions in ChatUtils. rather mark them as deprecated and delete them in 1-2 weeks in another pr.

The methods that were removed were never used/already deprecated or were only ever used once, the only function that wasnt deprecated or was never used was createHoverable which was only ever used in commands and I updated that usage. I dont see the point in keeping dead code for it to be deprecated for only a week

Deprecating code and then deleting it a week later makes no difference than just doing it now as it will just delay the possible PRs that could be using them to break in a week instead of now.

@CalMWolfs CalMWolfs requested a review from hannibal002 May 8, 2024 10:08
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were just so that open PRs with this code can one click fix the deprecated code instead of looking up and writing the necessary lines manually.
but those functions aren't often used anyway, it seems, so it's fine

@hannibal002 hannibal002 merged commit f9ce2fa into hannibal002:beta May 8, 2024
3 checks passed
@github-actions github-actions bot removed Bug Fix Bug fixes Backend A backend pull request that will be merged soon labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants