-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Text API #1718
Backend: Text API #1718
Conversation
…ble this for some cases
…t-utils # Conflicts: # src/main/java/at/hannibal2/skyhanni/data/ChatClickActionManager.kt # src/main/java/at/hannibal2/skyhanni/utils/ChatUtils.kt
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes. |
Conflicts have been resolved! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please dont delete/break existing functions in ChatUtils. rather mark them as deprecated and delete them in 1-2 weeks in another pr.
The methods that were removed were never used/already deprecated or were only ever used once, the only function that wasnt deprecated or was never used was createHoverable which was only ever used in commands and I updated that usage. I dont see the point in keeping dead code for it to be deprecated for only a week Deprecating code and then deleting it a week later makes no difference than just doing it now as it will just delay the possible PRs that could be using them to break in a week instead of now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thoughts were just so that open PRs with this code can one click fix the deprecated code instead of looking up and writing the necessary lines manually.
but those functions aren't often used anyway, it seems, so it's fine
What
This PR adds the
Text
object which is a file that contains numerous utilities for creating chat components. In addition to this it makes it easier to complete some todos that were related to components. This also cleans up the chat action manager to be a map to action to make sure lookups at O(1) instead of looping through all, it also moves it to the utilities package with the other components utils into a new packagechat
.Changelog Technical Details