Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Remind Command #1708

Merged
merged 35 commits into from
Aug 26, 2024
Merged

Conversation

ThatGravyBoat
Copy link
Contributor

@ThatGravyBoat ThatGravyBoat commented May 5, 2024

Dependencies

What

A continuation of #1129, finishing it. This adds the remind command along with some component utilities.

Images

2024-05-05_13 57 02

Changelog New Features

  • Added Remind command. - ThatGravyBoat & Zickles
    • Use /shremind <time> <note> to set reminders for your future self.

@ThatGravyBoat ThatGravyBoat changed the title Remind Command Feature: Remind Command May 5, 2024
@hannibal002 hannibal002 added this to the Version 0.26 milestone May 6, 2024
@ThatGravyBoat
Copy link
Contributor Author

Im going to pull out the text class into its own PR as I think its a little out of scope to keep it in here and I want to depend on it in other PRs, so while I do that ill make this as a draft

@ThatGravyBoat ThatGravyBoat marked this pull request as draft May 6, 2024 16:12
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
#	src/main/java/at/hannibal2/skyhanni/utils/chat/Text.kt
@ThatGravyBoat ThatGravyBoat marked this pull request as ready for review May 6, 2024 17:20
@ThatGravyBoat
Copy link
Contributor Author

Now updated to depend on the text api PR

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 6, 2024
Copy link

github-actions bot commented May 6, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Conflicts have been resolved! 🎉

@CalMWolfs CalMWolfs mentioned this pull request May 7, 2024
Copy link

github-actions bot commented May 8, 2024

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label May 8, 2024
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/commands/Commands.kt
#	src/main/java/at/hannibal2/skyhanni/utils/ChatUtils.kt
#	src/main/java/at/hannibal2/skyhanni/utils/chat/ChatClickActionManager.kt
#	src/main/java/at/hannibal2/skyhanni/utils/chat/Text.kt
@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label May 8, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 10, 2024
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 10, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 16, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/config/features/misc/MiscConfig.java
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Jun 16, 2024
@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Aug 20, 2024
Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!
Maybe we should show the help list when just doing "/shremind" instead of the one liner:
image

@hannibal002 hannibal002 merged commit 8852ced into hannibal002:beta Aug 26, 2024
4 checks passed
@github-actions github-actions bot removed the Soon This Pull Request will be merged within the next couple of betas label Aug 26, 2024
MTOnline69 pushed a commit to MTOnline69/SkyHanni that referenced this pull request Sep 11, 2024
Co-authored-by: Zickles <zicklesistaken@gmail.com>
Co-authored-by: Cal <cwolfson58@gmail.com>
Co-authored-by: hannibal2 <24389977+hannibal00212@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants