Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.19] fix: formkit selector not listening to data after defaulting to first option #6574

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #6571

/assign LIlGG

解决 formkit 选择器回显数据异常的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 2, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and LIlGG September 2, 2024 08:48
Copy link

sonarqubecloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.19@142f46b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-2.19    #6574   +/-   ##
===============================================
  Coverage                ?   58.05%           
  Complexity              ?     3917           
===============================================
  Files                   ?      670           
  Lines                   ?    22954           
  Branches                ?     1573           
===============================================
  Hits                    ?    13327           
  Misses                  ?     9010           
  Partials                ?      617           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
Copy link

f2c-ci-robot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit a0af1c2 into halo-dev:release-2.19 Sep 2, 2024
8 checks passed
@JohnNiang JohnNiang added this to the 2.19.1 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants