-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: formkit selector not listening to data after defaulting to first option #6571
Conversation
/cherrypick release-2.19 |
@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6571 +/- ##
============================================
- Coverage 58.18% 58.05% -0.13%
- Complexity 3774 3917 +143
============================================
Files 651 670 +19
Lines 22125 22954 +829
Branches 1538 1573 +35
============================================
+ Hits 12873 13327 +454
- Misses 8641 9010 +369
- Partials 611 617 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@LIlGG: new pull request created: #6574 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area ui
/milestone 2.20.x
What this PR does / why we need it:
当 formkit 选择器初始没有值的情况下,会默认选择第一项,但这同时会导致监听器取消监听,进而无法监听到后续的 value 值变更。
此 PR 将选择值的逻辑与自动选择第一项分开,用于解决此问题。
How to test it?
测试当选择器不存在初始值时,后续通过 v-model 传入的值是否还会使当前选项进行变更。
Does this PR introduce a user-facing change?