Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formkit selector not listening to data after defaulting to first option #6571

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Sep 2, 2024

What type of PR is this?

/kind bug
/area ui
/milestone 2.20.x

What this PR does / why we need it:

当 formkit 选择器初始没有值的情况下,会默认选择第一项,但这同时会导致监听器取消监听,进而无法监听到后续的 value 值变更。

此 PR 将选择值的逻辑与自动选择第一项分开,用于解决此问题。

How to test it?

测试当选择器不存在初始值时,后续通过 v-model 传入的值是否还会使当前选项进行变更。

Does this PR introduce a user-facing change?

解决 FormKit 选择器回显数据异常的问题

@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 2, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.20.x milestone Sep 2, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Sep 2, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and lan-yonghui September 2, 2024 04:28
@LIlGG
Copy link
Member Author

LIlGG commented Sep 2, 2024

/cherrypick release-2.19

@halo-dev-bot
Copy link
Collaborator

@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

sonarqubecloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.05%. Comparing base (6cd8dc8) to head (f3ac14c).
Report is 47 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6571      +/-   ##
============================================
- Coverage     58.18%   58.05%   -0.13%     
- Complexity     3774     3917     +143     
============================================
  Files           651      670      +19     
  Lines         22125    22954     +829     
  Branches       1538     1573      +35     
============================================
+ Hits          12873    13327     +454     
- Misses         8641     9010     +369     
- Partials        611      617       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2024
Copy link

f2c-ci-robot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 3c46358 into halo-dev:main Sep 2, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@LIlGG: new pull request created: #6574

In response to this:

/cherrypick release-2.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Sep 2, 2024
…ulting to first option (#6574)

This is an automated cherry-pick of #6571

/assign LIlGG

```release-note
解决 formkit 选择器回显数据异常的问题
```
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants