refactor: refresh the plugin wrapper when starting the plugin #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
f2c-ci-robot
bot
added
kind/bug
Codecov Report
@@ Coverage Diff @@
## main #4023 +/- ##
============================================
+ Coverage 60.52% 60.60% +0.08%
- Complexity 2380 2385 +5
============================================
Files 356 356
Lines 12317 12328 +11
Branches 891 891
============================================
+ Hits 7455 7472 +17
+ Misses 4422 4415 -7
- Partials 440 441 +1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
/cherry-pick release-2.6 |
|
@ruibaby: new pull request created: #4078 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
#### What type of PR is this? /kind improvement /area core /milestone 2.12.x #### What this PR does / why we need it: This PR reverts changes in PR <#4023>, mainly thanks to PR <#5148>. We don't need to refresh the plugin wrapper on every startup, because we entirely disable the plugin in plugin manager when disabling plugin at console. #### Which issue(s) this PR fixes: Fixes #4016 #### Does this PR introduce a user-facing change? ```release-note None ```
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
#### What type of PR is this? /kind cleanup /area plugin /milestone 2.17.x #### What this PR does / why we need it: 移除 BasePlugin 中已经过时的构造方法 在 2.6.1 版本中将 `BasePlugin(PluginWrapper wrapper)` 标记为过时并使用 `BasePlugin(PluginContext pluginContext)` 代替，现在已经过了很多版本，是时候移除它了。 see also #4023 #### Does this PR introduce a user-facing change? ```release-note 开发者相关：移除 BasePlugin 中已经过时的构造方法 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/kind bug
/area core
/area plugin
/milestone 2.6.x
What this PR does / why we need it:
修复插件重启后 MainClass 对象缓存未清除的问题
how to test it?
下载此插件：
plugin-starter-1.0.0-SNAPSHOT.jar.zip
安装并启动插件，会看到类似如下日志：
修改日志中给出的文件的内容后 reload 插件会看到
插件启动成功！后会跟随最新的文件内容则表示 MainClass 是最新的状态没有缓存。Which issue(s) this PR fixes:
Fixes #4016
Does this PR introduce a user-facing change?