Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup deprecated constructor for base plugin #6243

Merged
merged 1 commit into from
Jul 3, 2024
Merged

chore: cleanup deprecated constructor for base plugin #6243

merged 1 commit into from
Jul 3, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented Jul 1, 2024

What type of PR is this?

/kind cleanup
/area plugin
/milestone 2.17.x

What this PR does / why we need it:

移除 BasePlugin 中已经过时的构造方法

在 2.6.1 版本中将 BasePlugin(PluginWrapper wrapper) 标记为过时并使用 BasePlugin(PluginContext pluginContext) 代替，现在已经过了很多版本，是时候移除它了。

see also #4023

Does this PR introduce a user-facing change?

开发者相关：移除 BasePlugin 中已经过时的构造方法

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.17.x milestone Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG July 1, 2024 09:36
@f2c-ci-robot f2c-ci-robot bot added the area/plugin Issues or PRs related to the Plugin Provider label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from ruibaby July 1, 2024 09:36
@codecov Codecov
Copy link

codecov bot commented Jul 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.06%. Comparing base (bc10336) to head (77583c0).
Report is 59 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6243      +/-   ##
============================================
+ Coverage     54.51%   58.06%   +3.55%     
- Complexity     3523     3749     +226     
============================================
  Files           646      647       +1     
  Lines         21862    21963     +101     
  Branches       1528     1536       +8     
============================================
+ Hits          11917    12752     +835     
+ Misses         9328     8594     -734     
  Partials        617      617

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang
Copy link
Member

/milestone 2.18.x

移除改构造函数会造成很多插件无法启动。建议等 Halo 2.17.0 发布之后再合并，并通过各个渠道通知插件开发者我们将正式在 2.18 中移除过时的构造函数。

/hold

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
@f2c-ci-robot f2c-ci-robot bot modified the milestones: 2.17.x, 2.18.x Jul 1, 2024
This was referenced Jul 2, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-highlightjs that referenced this pull request Jul 2, 2024
@guqing
chore: remove deprecated plugin wrapper (#19)
b30e14c 
### What this PR does?
移除对已过时的 PluginWrapper 的引用，Halo 2.18.0 版本后将不在支持从 BasePlugin 中获取 PluginWrapper ，也不再支持依赖注入 PluginWrapper，使用 PluginContext 代替

see also halo-dev/halo#6243 for more details

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-photos that referenced this pull request Jul 2, 2024
@guqing
chore: remove deprecated plugin wrapper (#46)
78d87dd 
### What this PR does?
移除对已过时的 PluginWrapper 的引用，Halo 2.18.0 版本后将不在支持从 BasePlugin 中获取 PluginWrapper ，也不再支持依赖注入 PluginWrapper，使用 PluginContext 代替

see also halo-dev/halo#6243 for more details

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-lightgallery that referenced this pull request Jul 2, 2024
@guqing
chore: remove deprecated plugin wrapper (#19)
5d18a15 
### What this PR does?
移除对已过时的 PluginWrapper 的引用，Halo 2.18.0 版本后将不在支持从 BasePlugin 中获取 PluginWrapper ，也不再支持依赖注入 PluginWrapper，使用 PluginContext 代替

see also halo-dev/halo#6243 for more details

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-editor-hyperlink-card that referenced this pull request Jul 2, 2024
@guqing
chore: remove deprecated plugin wrapper (#6)
d7cde80 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243 for more details

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-migrate that referenced this pull request Jul 2, 2024
@guqing
chore: remove deprecated plugin wrapper (#53)
d72671a 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243 for more details

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-oauth2 that referenced this pull request Jul 2, 2024
@guqing
chore: remove deprecated plugin wrapper (#49)
44ca501 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243 for more details

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-dev/plugin-s3 that referenced this pull request Jul 2, 2024
@guqing
chore: remove deprecated plugin wrapper (#161)
40f66ff 
### What this PR does?
移除对已过时的 PluginWrapper 的引用，Halo 2.18.0 版本后将不在支持从 BasePlugin 中获取 PluginWrapper ，也不再支持依赖注入 PluginWrapper，使用 PluginContext 代替

see also halo-dev/halo#6243 for more details

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-dev/plugin-sitemap that referenced this pull request Jul 2, 2024
@guqing
chore: remove deprecated plugin wrapper (#33)
2b3ffae 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-dev/plugin-search-widget that referenced this pull request Jul 3, 2024
@guqing
chore: remove deprecated plugin wrapper (#34)
2f792aa 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-dev/plugin-feed that referenced this pull request Jul 3, 2024
@guqing
chore: remove deprecated plugin wrapper (#31)
9c332d4 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243

```release-note
None
```
JohnNiang
JohnNiang approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halo 2.17.0 已经发布。

/unhold
/lgtm

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2024
@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2024
@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Jul 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit b964c7b into halo-dev:main Jul 3, 2024
7 checks passed
@guqing guqing deleted the chore/cleanup branch July 3, 2024 03:49
@ruibaby ruibaby mentioned this pull request Jul 4, 2024
Merged
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-umami that referenced this pull request Jul 4, 2024
@ruibaby
chore: remove deprecated plugin wrapper (#25)
d90548c 
### What this PR does?
移除对已过时的 PluginWrapper 的引用，Halo 2.18.0 版本后将不在支持从 BasePlugin 中获取 PluginWrapper ，也不再支持依赖注入 PluginWrapper，使用 PluginContext 代替

see also halo-dev/halo#6243 for more details

```release-note
None
```
This was referenced Jul 5, 2024
Merged
Merged
Merged
Merged
Merged
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-stackedit that referenced this pull request Jul 5, 2024
@ruibaby
chore: remove deprecated plugin wrapper (#11)
18ad616 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-unsplash that referenced this pull request Jul 5, 2024
@ruibaby
chore: remove deprecated plugin wrapper (#12)
c57893e 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-katex that referenced this pull request Jul 5, 2024
@ruibaby
chore: cleanup deprecated constructor for base plugin (#19)
576eecb 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-bytemd that referenced this pull request Jul 5, 2024
@ruibaby
chore: cleanup deprecated constructor for base plugin (#39)
157010d 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243

```release-note
None
```
f2c-ci-robot bot pushed a commit to halo-sigs/plugin-text-diagram that referenced this pull request Jul 5, 2024
@ruibaby
chore: cleanup deprecated constructor for base plugin (#14)
9e3a4bc 
### What this PR does?
移除对已过时的 PluginWrapper 的引用

see also halo-dev/halo#6243

```release-note
None
```
@ruibaby ruibaby modified the milestones: 2.18.x, 2.18.0 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@ruibaby ruibaby Awaiting requested review from ruibaby

Assignees

@JohnNiang JohnNiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/plugin Issues or PRs related to the Plugin Provider kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guqing @JohnNiang @ruibaby