-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed backlash / in img tag (<img.../>) in CONTRIBUTING.md #7280
Removed backlash / in img tag (<img.../>) in CONTRIBUTING.md #7280
Conversation
…ut an ending slash (<img...>). Section 2.7.d of CONTRIBUTING.md
Want to review this pull request? Take a look at this documentation for a step by step guide! Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
ETA: Thu Aug 15th, 11:59pm PST |
Availability: 7 am to 11 am on weekdays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @santisecco, Nicely done!
- The branches from and to are setup correctly
- Link to the issue is included
- There is a clear and concise description of what was done and why
- No changes were made to the website
Thanks for woking on this issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, everything looks solid on this PR and the file change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @santisecco,
The changes made look good!
- branching to and from is correct
- changes made and why they were made are clearly stated
img
tag has ending slash removed
Thanks for contributing!
Fixes #7098
What changes did you make?
Why did you make the changes (we will use this info to test)?
For Reviewers: Do not test changes locally, rather test changes at https://github.com/santisecco/website/blob/img-tag-refactor-contributing-7098/CONTRIBUTING.md
Screenshots of Proposed Changes Of The Website