Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed backlash / in img tag (<img.../>) in CONTRIBUTING.md #7280

Conversation

santisecco
Copy link
Member

@santisecco santisecco commented Aug 13, 2024

Fixes #7098

What changes did you make?

  • In section 2.7.d of CONTRIBUTING.md removed the backlash / in the img tag (<img.../>) to an img tag without an ending backslash (<img...>).

Why did you make the changes (we will use this info to test)?

  • So that the codebase is consistent with how we use img HTML tags.

For Reviewers: Do not test changes locally, rather test changes at https://github.com/santisecco/website/blob/img-tag-refactor-contributing-7098/CONTRIBUTING.md

Screenshots of Proposed Changes Of The Website

  • No visual changes were made to the website.

…ut an ending slash (<img...>). Section 2.7.d of CONTRIBUTING.md
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/santisecco/website/blob/img-tag-refactor-contributing-7098/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML size: 0.5pt Can be done in 3 hours or less labels Aug 13, 2024
@terrencejihoonjung
Copy link
Member

ETA: Thu Aug 15th, 11:59pm PST
Availability: Mon-Fri (all day)

@buneeIsSlo
Copy link
Member

Availability: 7 am to 11 am on weekdays
ETA: before 14-AUG-24 e.o.d

Copy link
Member

@buneeIsSlo buneeIsSlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @santisecco, Nicely done!

  • The branches from and to are setup correctly
  • Link to the issue is included
  • There is a clear and concise description of what was done and why
  • No changes were made to the website

Thanks for woking on this issue!

Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, everything looks solid on this PR and the file change.

Copy link
Member

@terrencejihoonjung terrencejihoonjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @santisecco,

The changes made look good!

  • branching to and from is correct
  • changes made and why they were made are clearly stated
  • img tag has ending slash removed

Thanks for contributing!

@t-will-gillis t-will-gillis merged commit fbb9cb1 into hackforla:gh-pages Aug 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging this pull request may close these issues.

img tag refactor in CONTRIBUTING.md Sec 2.7.d
5 participants