img tag refactor in CONTRIBUTING.md Sec 2.7.d

[roslynwythe]

Prerequisite

1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Action Items

• In your local IDE, open the file CONTRIBUTING.md
• In Section 2.7.d change

<img src="https://raw.githubusercontent.com/wiki/hackforla/website/images/how-to-review-pull-requests/step3-sync-demo.gif" />

to

<img src="https://raw.githubusercontent.com/wiki/hackforla/website/images/how-to-review-pull-requests/step3-sync-demo.gif">

• The file may contain more than one instance of an img tag with a closing slash. Only change the single instance specified above. Do not leave any blank spaces before the closing bracket.
• Changes to CONTRIBUTING.md cannot be tested locally, rather they must be tested after pushing the issue branch to your fork of the repository. Push your issue branch in the usual manner, but before creating the Pull Request, check your updates using this test URL (also store the test URL for use in a later step)

https://github.com/[REPLACE WITH GITHUB HANDLE]/website/blob/[REPLACE WITH NAME OF ISSUE BRANCH]/CONTRIBUTING.md

(for example: https://github.com/roslynwythe/website/blob/test-CONTRIB/CONTRIBUTING.md)

• Create a pull request with your changes. In the Pull Request, after the "Why did you make the changes" section, add this line to help reviewers, replacing the text in brackets (and the brackets) with the test URL from the previous Action Item.

For Reviewers: Do not test changes locally, rather test changes at [REPLACE WITH TEST URL]

Merge Team

• After closing this issue, check off the dependency in epic: Refactor img tags in CONTRIBUTING.md to end without a slash #6453. If all dependecies have been completed, close epic: Refactor img tags in CONTRIBUTING.md to end without a slash #6453 and check off its dependency in Rollout Plan: Refactor code with img HTML tags to end without a slash #4362. If all dependencies have been completed in Rollout Plan: Refactor code with img HTML tags to end without a slash #4362, close it.

Resources/Instructions

1. Webpage(s): https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md
2. This issue is part of epic: Refactor img tags in CONTRIBUTING.md to end without a slash #6453

[santisecco]

i. Availability: Today 7-23 and 7-24
ii. ETA: 7-25

[santisecco]

Hi, I have a blocker.

I opened CONTRIBUTING.md from the following path in my local folder hackforla\website\CONTRIBUTING.md but couldn't find

<img src="https://docs.github.com/assets/cb-49937/images/help/repository/update-branch-button.png" />

Instead I found in section 2.7.d

<img src="https://raw.githubusercontent.com/wiki/hackforla/website/images/how-to-review-pull-requests/step3-sync-demo.gif" />

I couldn't find the specified img tag in another place though.
Any assistance is appreciated, thank you.

[github-actions]

@santisecco

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
2. Blockers: "Difficulties or errors encountered."
3. Availability: "How much time will you have this week to work on this issue?"
4. ETA: "When do you expect this issue to be completed?"
5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

_{You are receiving this comment because your last comment was before Tuesday, July 30, 2024 at 12:05 AM PST.}

[santisecco]

I will send the blocker in Slack for someone to help me.

[t-will-gillis]

Hey @santisecco Would you please post your blocker on this issue? Thanks!

[santisecco]

Sure I posted it a while ago further up. Next time I'll post it again. It's about the "src" link of the image tag

Hi, I have a blocker.

I opened CONTRIBUTING.md from the following path in my local folder hackforla\website\CONTRIBUTING.md but couldn't find
<img src="https://docs.github.com/assets/cb-49937/images/help/repository/update-branch-button.png" />

Instead I found in section 2.7.d

<img src="https://raw.githubusercontent.com/wiki/hackforla/website/images/how-to-review-pull-requests/step3-sync-demo.gif" />

I couldn't find the specified img tag in another place though.
Any assistance is appreciated, thank you.

--- however I do think that the issue is referring to the link <img src="https://raw.githubusercontent.com/wiki/hackforla/website/images/how-to-review-pull-requests/step3-sync-demo.gif" />

[t-will-gillis]

Hi @santisecco Yes, I agree- I edited the description above to match. Thanks for asking the question!