Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Karen Coronel Leadership detail for civic jobs project page #5451

Merged

Conversation

locb65
Copy link
Member

@locb65 locb65 commented Sep 5, 2023

Fixes #5383

What changes did you make?

  • Updated Karen Coronel info on Civic jobs page under leadership
  • Moved Karen Coronel up to the top of leadership

Why did you make the changes (we will use this info to test)?

  • To update Karen Coronel's position
  • To move Karen Coronel higher on the list to reflect her new position

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied. Civic Jobs (leadership)

good second issue before - leadership Karen Coronel

Visuals after changes are applied. Civic Jobs (leadership)

good second issue after-leadership Karen Coronel
aching_Files)

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b locb65-update-project-profile-#5383 gh-pages
git pull https://github.com/locb65/website.git update-project-profile-#5383

@locb65 locb65 requested a review from janice87 September 5, 2023 22:54
@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 5, 2023
@LRenDO LRenDO self-requested a review September 7, 2023 06:35
LRenDO
LRenDO previously approved these changes Sep 7, 2023
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @locb65!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • Changes were made correctly in the code
  • Changes appear correctly on the site. The position and title have been changed correctly.
  • Relevant images were included
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

Again, nice work and thanks for taking the time to contribute to the website!

t-will-gillis
t-will-gillis previously approved these changes Sep 9, 2023
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @locb65! Your from and into branches are good, you are linked back to the issue, you have provided the reasons for what you did and why, and you include before and after screenshots. Finally, your code edits are cleanly made and it checks out in Docker. Thanks for working on this issue!

@t-will-gillis t-will-gillis dismissed stale reviews from LRenDO and themself via 5ab30f0 September 9, 2023 05:24
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a merge conflict, resolved now

@t-will-gillis t-will-gillis merged commit a7eae38 into hackforla:gh-pages Sep 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs (edits to Karen Coronel)
3 participants