-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Karen Coronel Leadership detail for civic jobs project page #5451
Update Karen Coronel Leadership detail for civic jobs project page #5451
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @locb65!
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- Changes were made correctly in the code
- Changes appear correctly on the site. The position and title have been changed correctly.
- Relevant images were included
- The PR request clearly states what was updated
- The PR request states why the changes are being made
Again, nice work and thanks for taking the time to contribute to the website!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @locb65! Your from and into branches are good, you are linked back to the issue, you have provided the reasons for what you did and why, and you include before and after screenshots. Finally, your code edits are cleanly made and it checks out in Docker. Thanks for working on this issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a merge conflict, resolved now
Fixes #5383
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied. Civic Jobs (leadership)
Visuals after changes are applied. Civic Jobs (leadership)
aching_Files)