Skip to content

Conversation

seanjparker
Copy link
Collaborator

Resolves #7

  • Updates LICENSE year
  • Adds support for unverified application state
  • Add review page
  • Add review submit route, controller
  • Add controller method to get next application to review w/ < 2 total reviews, not reviewed by current user
  • Add properties to ApplicationMapped decorator for review mapping
  • Adds support for maxLength property in long application questions
  • Updates navbar to support unverified application state

@seanjparker seanjparker added the feature New feature or request label Mar 2, 2020
@seanjparker seanjparker added this to the SH 2020 milestone Mar 2, 2020
@codecov-io
Copy link

codecov-io commented Mar 3, 2020

Codecov Report

Merging #35 into master will increase coverage by 6.05%.
The diff coverage is 67.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   62.64%   68.69%   +6.05%     
==========================================
  Files          36       44       +8     
  Lines         803      936     +133     
  Branches       89       96       +7     
==========================================
+ Hits          503      643     +140     
+ Misses        292      282      -10     
- Partials        8       11       +3
Impacted Files Coverage Δ
src/types.ts 100% <ø> (ø) ⬆️
src/util/index.ts 100% <100%> (ø) ⬆️
src/models/db/reviews/review.ts 100% <100%> (ø)
src/util/decorator/index.ts 100% <100%> (ø)
src/models/db/reviews/index.ts 100% <100%> (ø)
src/inversify.config.ts 100% <100%> (ø) ⬆️
src/repositories/repositories.ts 100% <100%> (ø) ⬆️
src/controllers/applicationController.ts 90.54% <100%> (ø) ⬆️
src/routes/reviewRouter.ts 100% <100%> (ø)
src/models/db/applicant/index.ts 100% <100%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e2b6f...f543506. Read the comment docs.

@seanjparker seanjparker mentioned this pull request Mar 11, 2020
@seanjparker seanjparker marked this pull request as ready for review May 25, 2020 13:36
@codecov-commenter
Copy link

Codecov Report

Merging #35 into master will increase coverage by 5.21%.
The diff coverage is 62.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   62.64%   67.85%   +5.21%     
==========================================
  Files          36       44       +8     
  Lines         803      952     +149     
  Branches       89       97       +8     
==========================================
+ Hits          503      646     +143     
- Misses        292      295       +3     
- Partials        8       11       +3     
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)
src/services/applications/applicantService.ts 77.04% <16.66%> (-14.79%) ⬇️
src/controllers/reviewController.ts 26.53% <26.53%> (ø)
src/services/review/reviewService.ts 60.00% <60.00%> (ø)
src/util/decorator/decorators.ts 92.30% <92.30%> (ø)
src/controllers/applicationController.ts 90.54% <100.00%> (ø)
src/controllers/index.ts 100.00% <100.00%> (ø)
src/inversify.config.ts 100.00% <100.00%> (ø)
src/models/db/applicant/applicant.ts 100.00% <100.00%> (ø)
src/models/db/applicant/index.ts 100.00% <100.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6857f80...e71ed3e. Read the comment docs.

@seanjparker seanjparker merged commit 01c1d33 into master May 26, 2020
@seanjparker seanjparker deleted the application-review branch May 26, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application rating system
3 participants