Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Feature merge (dev to master) #75

Merged
merged 55 commits into from
May 17, 2021
Merged

Feature merge (dev to master) #75

merged 55 commits into from
May 17, 2021

Conversation

neoblizz
Copy link
Member

  • Complete Betweenness Centrality
  • Batched Operator
  • PageRank Nibble (LGC)
  • AtomicMax support
  • cmake clean-up
  • Manual frontier management, enactor improvements
  • COO, CSC functionality

Ubuntu and others added 30 commits April 22, 2021 02:30
Incorrect index in `thrust::inclusive_scan`.

Previously (incorrect):
```
0 0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2 2 2 2 3 3 3 3 4 4 4 4 5 5 5 0 6 0 0 0 0 0 0 0 0 0 7 0 0 0 0 0 0 0 0 0 0 0 0 8 0 0 0 0 0 0 9 0 0 0 0 10 0 0 0 0 0 0 11 0 0 0 0 0 0 0 0 12 0 0 0 0 0 0 13 0 0 0 0 0 0 0 14 0 0 0 0 0 0 0 0 15 0 0 0 0 16 0 0 0 17 0 0 0 0 0 0 0 0 18 0 0 0 0 0 0 0 0 19 0 0 0 20 0 0 0 0 21 0 0 0 0 0 0 0 0 0 0 0 0 22 0 0 0 0 0 0 0 0 0 23 0 0 0 24 0 0 0 0 0 25 0 0 0 0 0 0 26 0 0 0 0 0 0 0 0 27 0 0 0 0 0 28 0 0 0 0 0 29 0 0 0 0 0 30 0 0 0 0 31 0 0 0 0 0 0 32 0 0 0 0 0 0 33 0 0 34 0 0 0 0 0 0 0 0 0 0 0 0 0 0 35 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 36 0 0 0 37 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 38 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 
```

W/ this fix (correct):
```
0 0 0 0 0 0 0 0 0 0 0 1 1 1 1 1 1 1 1 1 1 1 2 2 2 2 2 2 2 3 3 3 3 4 4 4 4 5 5 5 5 6 6 6 6 6 6 6 6 6 6 7 7 7 7 7 7 7 7 7 7 7 7 7 8 8 8 8 8 8 8 9 9 9 9 9 10 10 10 10 10 10 10 11 11 11 11 11 11 11 11 11 12 12 12 12 12 12 12 13 13 13 13 13 13 13 13 14 14 14 14 14 14 14 14 14 15 15 15 15 15 16 16 16 16 17 17 17 17 17 17 17 17 17 18 18 18 18 18 18 18 18 18 19 19 19 19 20 20 20 20 20 21 21 21 21 21 21 21 21 21 21 21 21 21 22 22 22 22 22 22 22 22 22 22 23 23 23 23 24 24 24 24 24 24 25 25 25 25 25 25 25 26 26 26 26 26 26 26 26 26 27 27 27 27 27 27 28 28 28 28 28 28 29 29 29 29 29 29 30 30 30 30 30 31 31 31 31 31 31 31 32 32 32 32 32 32 32 33 33 33 34 34 34 34 34 34 34 34 34 34 34 34 34 34 34 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 35 36 36 36 36 37 37 37 37 37 37 37 37 37 37 37 37 37 37 37 37 37 37 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 38 
```
Order of values passed to `csc.set` is incorrect.  

More descriptive names than `Aj`, `Ap`, `Ax` might be helpful here.  

Likewise, more descriptive names thatn `Ap`, `J`, `X`, `I` and `Aj` would be helpful in `graph/build/detail.hxx`.  Any reason not to use the following?
```
row_offsets
column_indices
nonzero_values
row_indices
column_offsets
```

Or ... in my opinion even better because they're shorter, the same length 😄 and `nonzero_values` is redundant:
```
row_offsets
col_indices
values
row_indices
col_offsets
```
[BUGFIX] Order of values passed to `csc.set`
[APP] Betweenness Centrality (V3)
@neoblizz neoblizz added 🍍 algorithms New or existing graph algorithms question. 🏡 api API related changes, suggestions, issues. 🏭 build Build related issues. 🐛 bug Something isn't working 🐲 enhancement New feature or request labels May 17, 2021
@neoblizz neoblizz merged commit c54f6d5 into master May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🍍 algorithms New or existing graph algorithms question. 🏡 api API related changes, suggestions, issues. 🐛 bug Something isn't working 🏭 build Build related issues. 🐲 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants