Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Implementing COO graph functions #62

Merged
merged 2 commits into from
May 1, 2021
Merged

Conversation

bkj
Copy link
Contributor

@bkj bkj commented Apr 29, 2021

  • Implement get_number_of_neighbors, get_starting_edge and get_edge for COO
  • Implement examples/test_coo for spot-checking these functions.

I think the implementations are correct, but worth someone double checking.

@neoblizz One thing:
In graph/detail/build.hxx I had to change

using graph_type = graph::graph_t<space, vertex_t, edge_t, weight_t, csr_v_t, csc_v_t, coo_v_t>;

to

using graph_type = graph::graph_t<space, vertex_t, edge_t, weight_t, coo_v_t>;

otherwise it complains about

error: class "gunrock::graph::empty_csr_t" has no member "get_source_vertex"

I think this means you might need to modify how the inheritance works in graph/graph.hxx but I'll leave that to you.

Do not merge this until that view issue is fixed, otherwise it'll break stuff.

neoblizz and others added 2 commits April 23, 2021 09:58
Bug-fixes, minor enhancements and clean-up with unit tests.
@neoblizz neoblizz changed the base branch from master to dev April 29, 2021 04:19
@neoblizz
Copy link
Member

  • Implement examples/test_coo for spot-checking these functions.

I have moved all the unit tests to https://github.com/gunrock/essentials/tree/master/unittests instead of the examples directory. It also supports cmake now, please use that instead.

And merge all the PRs to dev instead, I am changing the base of this one as well.

@neoblizz
Copy link
Member

Do not merge this until that view issue is fixed, otherwise it'll break stuff.

I will look at the empty_t problem, I thought I had already addressed it.

@neoblizz neoblizz added 🐙 c++ C++ related issues. 🔬 experiment Figures, experiments to understand performance. labels Apr 29, 2021
@neoblizz neoblizz added 🐲 enhancement New feature or request and removed 🔬 experiment Figures, experiments to understand performance. labels Apr 29, 2021
@neoblizz neoblizz self-assigned this May 1, 2021
@neoblizz neoblizz merged commit c51ef9d into gunrock:dev May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐙 c++ C++ related issues. 🐲 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants