Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.24.0 upgrade #140

Merged
merged 469 commits into from
Dec 5, 2023
Merged

v8.24.0 upgrade #140

merged 469 commits into from
Dec 5, 2023

Conversation

Jakeii
Copy link
Member

@Jakeii Jakeii commented Nov 23, 2023

Upgrade to Prebid v8

pm-priyanka-deshmane and others added 30 commits August 25, 2023 06:26
* Enable supplyChain support

* Added support for COPPA

* rebuilt

* Added support for Extended User IDs.

* Added support for the "meta" attribute in bid response.

* Delete nobidBidAdapter.js.orig

* Delete a

* Delete .jsdtscope

* Delete org.eclipse.wst.jsdt.ui.superType.container

* Delete org.eclipse.wst.jsdt.ui.superType.name

* Delete .project

* New NoBid Analytics Adapter.

* Added NoBid Analytics Adapter unit tests.

* Added NoBid Analytics Module documentation.

---------

Co-authored-by: Reda Guermas <reda.guermas@nobid.io>
* Initial implementation of kulturemedia bid adapter

* Changing outstream to instream

* Enriching md file with test examples

* Changing nId to networkId

* Cleaning up md file

* Submitting rebranded dxkultureBidAdapter

---------

Co-authored-by: kmdevops <devops@kulture.media>
Co-authored-by: Michele Nasti <michele@magnite.com>
Co-authored-by: Maxi <mzurita@MacBook-Air-de-Maxi.local>
…win ad unit (prebid#10330)

* gptPreAuction: fix bug where adServer object are not set in case of twin ad unit

* refactor(GH suggestion): ortb2Imp.ext.data.adserver parameter settings
* Update tripleliftBidAdapter.js

* Update tripleliftBidAdapter.js
* drop atype for rubicon eid

* i spell bad
…rebid#10290)

* fix(bliink): bid ttl

* fix(bliink): ttl unit tests

* Bliink Bid Adapter: enhance request data with userIds, ect, refresh

* Bliink Bid Adapter: fix tests

---------

Co-authored-by: Samous <samuel@bliink.io>
Co-authored-by: stingaciutiberiu <tiberiu.stingaciu@sevio.com>
Bumps [tibdex/github-app-token](https://github.com/tibdex/github-app-token) from 1.8.0 to 1.8.2.
- [Release notes](https://github.com/tibdex/github-app-token/releases)
- [Commits](tibdex/github-app-token@b625283...0d49dd7)

---
updated-dependencies:
- dependency-name: tibdex/github-app-token
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* new bidder adapter: pangle

* feat:  parameter consistency

* feat: remove history

* fix: pangle

---------

Co-authored-by: xuqi.ziogie <xuqi.ziogie@bytedance.com>
…int (prebid#10404)

* Cadent Aperture MX Bid Adapter: Include gpp string and section id in usersync endpoint

* Cadent Aperture MX Bid Adapter: lint fix

---------

Co-authored-by: Michael Denton <mdenton@cadent.tv>
…field in config was changed inside the funtions. Added test script example in the documentation. (prebid#10413)
* new boldwin bid adapter

* fix

* Restarting ci / circleci

* changes

* fixed conflicts

* added endpointId param

* kick off CircleCI tests

* gpp

---------

Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
Co-authored-by: Vladislav Isaiko <vladis@smartyads.com>
Co-authored-by: Mykhailo Yaremchuk <m.yaremchuk@smartyads.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
…10442)

* Core: fill in `video.plcmt` when possible

* Core: use `playbackmethod` instead of `playmethod` for video
* Tapad RTD Submodule

* add publisher ids functionality to Tapad RTD submodule

* add no track logic, and make account id be string

* use rtid as prefix

* properly access params

* namespace ortb2 data

* rename to experian

* update markdown
* added a note on using multiple wrappers

* fix old links
dgirardi and others added 23 commits November 13, 2023 14:31
* reject bids when auction times out before rates are available

* retry loading rates after errors

* do not use import star
Co-authored-by: lvhuixin <lvhuixin@baidu.com>
* add adstir bidder adapter

* fix userIdAsEids typo
Add some fields from bidRequest.mediaTypes.video to backend bid
request
* TPMN Support Video

* add video param plcmt

* update ortb bcat,badv,bapp

* instream video is sound on default, outstream video sound off default

* remove VIDEO_ORTB_PARAMS, BANNER_ORTB_PARAMS

* fixed incorrect placement default format & update example

* update test case (Your tests failed on CircleCI)

* Revert "remove VIDEO_ORTB_PARAMS, BANNER_ORTB_PARAMS"

This reverts commit 2699115.

* Remove unnecessary code to meet guidelines.

* Remove unnecessary code to meet guidelines.

* fix Build fail

* delete logging code

---------

Co-authored-by: changjun <changjun@tpmn.io>
* initial 33across Analytics Adapter commit

* refactoring + additional unit test coverage

* Additional refactoring of 33x analytics unit tests

* Apply CR feedback
- Single responsibility for transaction manager
- Send one report per auction
- Clear pending events that were causing conflicts in specs

* refactoring of "incomplete state" unit test

* unit test coverage for duplicate transaction id

* Add additional spec about non found transaction

* obtain user ids via bid request, not via global fn.

* Populate bid response fields for BID WON events

* Prepare the cache for the bidresponse field population

* populate bidResponse field

* fix some typedef + remove unnecessary switch event cases

* Populate bids based on BID_RESPONSE and not on the bidsReceived field of AUCTION_END

* Populate floor CMP field

* fix eslint errors

* keep track of bids when bid_response event is received

* Additional fn documentation

* change jsdoc naming + spec refactoring

* remote siteId, make endpoint specification optional (provide default), refactoring, fix tests

* remove extraneous logs

* simplify GAM logging

* remove hardcoded version

* general improvements to documentation with fixes to jsdoc types

* update tests for style conformance

* IDG-677/remove code related to GAM slotRenderEnded

* IDG-677/remove typegen hint, and replace with jsdoc ref

* IDG-677/replace bidsWon with hasWon field, add sendReport trigger on auctionEnd (in the case that auction ends AND not all bids have resolved), and general refactoring

* IDG-677/update tests to ensure reports always match new spec, and general refactoring

* IDG-677/add fallback to use adUnitCode as slotId if "ortb2Imp.ext.{gpid,data.pbadslot}" values are both missing

* remove accidental file commits

Ticket: IDG-677

* test that report is being sent as soon as all transactions for auction are completed

Ticket: IDG-677

* remove extraneous transaction manager counting & status mechanism and track transactionIds directly

Ticket: IDG-677

* set default transaction timeout to 10s to better accommodate slower auctions, reverse auctionEnd and bidWon as the default sequence in test event emission, test for wider range of auction scenarios, improvements to clarity/specificity (naming)

Ticket: IDG-677

* fix invalid timeout test

Ticket: IDG-677

* add support for usp

Ticket: IDG-677

* pre-clear event emitter in case state not cleared by other test suites

Ticket: IDG-677

* tests: switch pre-clearing of "events" state with initiating our own stub of "events" emitter

Ticket: IDG-677

* adopt default endpoint without logging when endpoint value is unspecified

Ticket: IDG-677

* update docs to better reflect analytics adapter standard use-case and behavior

Ticket: IDG-677

* refactoring: renaming and reducing mocks to only event data used

Ticket: IDG-677

* remove usp consent string invalid test

Ticket: IDG-677

* log values as copy

Ticket: IDG-829

* fix early send issue by removing auto-send on auctionEnd and using "all GAM slots rendered" as an indicator for "complete enough" report after short delay

Ticket: IDG-829

* add gdpr, gpp, and coppa support

Ticket: IDG-803

* send gdprConsent string even if gdprApplies is false. Use array instead of comma string for gpp applicableSections.

Ticket: IDG-803

* fix tests to reflect updated bid.status => hasWon logic

Ticket: IDG-829

* remove errant log

Ticket: IDG-829

* remove extraneous call to isGptPubadsDefined

Ticket: IDG-829

* alter scope of subscribeToGamSlots

Ticket: IDG-829

* combine bidStatus / getCachedBid functions, add our own BidStatus enum to track possible choices

Ticket: IDG-829

* refactoring: renaming, fix reversion, better cloning for logs

Ticket: IDG-829

* test label revision

Ticket: IDG-829

* fix logic for test, "when an AUCTION_END event is received before BID_WON events: sends a report with the bids that have won after timeout"

Ticket: IDG-829

* reorganization of functions, fix to BIDDER_ERROR issue

Ticket: IDG-829

* remove try/catch convenience

Ticket: IDG-829

* test slotRenderEnded timeout

Ticket: IDG-829

* enable remainder of tests

Ticket: IDG-829

* added additional GAM tests

Ticket: IDG-829

* remove conditional language from GAM tests

Ticket: IDG-829

* Use floorValue instead of cpmAfterAdjustments as the price floor. Resolves IDG-1093.

* Mark bid as won on impression only. Resolves IDG-1107.

* Obtain rejected bid ID from requestId instead of bidId. Include rejected bid information in the report. Resolves IDG-1112.

* 33Across Analytics: Update DEFAULT_ENDPOINT to match production endpoint

* 33Across Analytics: Update docs - change pid type to string, plus other minor tweaks.

* 33Across Analytics docs: Add UIM reference

* Log a warning on ad slot ID mismatch instead of throwing an unhandled exception

* 33Across Analytics: Allow slots to be by configured by element ID instead of GAM ad unit code. Resolves IDG-1163.

* 33Across Analytics: Update contact e-mail; add instructions on enabling existing customers forAnalytics.

* 33Across Analytics spec: Ensure that mock GPT remains enabled after the tests finish

---------

Co-authored-by: Michael Scott-Nelson <michael.scott-nelson@33across.com>
Co-authored-by: Carlos Felix <carlos.felix@33across.com>
Co-authored-by: Joshua Poritz <joshua.poritz@33across.com>
* Added Media Filter Real Time Data Provider Module

* fixed eslint errors

* Modified MEDIAFILTER_EVENT_TYPE in unit tests

* re-trigger pipeline

* removed blank space

* re-trigger pipelines

* updated readme

* added mediafilter to adloader.js and submodules.json
Co-authored-by: francesco <f.orazini@onetag.com>
…d Module (prebid#10713)

* forward gppSections and gppString to LC

* fix package-lock
* Missena: floor implementation

* Missena: only floor, tests

* Missena: pass adServerCurrency to server

* Remove the custom calculation of the size parameter in getFloor()

---------

Co-authored-by: youssef <youssef.bsf@gmail.com>
…pes (prebid#10730)

* FreeWheel add floor price

* FreeWheel code update

* FreeWheel-SSP-Adapter: Update to use Vast 4.2 by default

* FreeWheel-SSP-Adapter add userIdAsEids support

* Freewheel-SSP-Adapter add test for eids

* Freewheel SSP Adapter: add prebid version in request

* code cleanup

* FreeWheel SSP Bid Adapter: support video context and placement

* update test

* FreeWheel SSP Bid Adapter: add GPP support

* Freewheel SSP Bid Adapter: test update

* FreeWheel SSP Adapter: update the default value for video placement and context

* update test

* FreeWheel SSP Adapter: add support for video.plcmt

* FreeWheel Adapter: support content object in config

* code update

* FreeWheel SSP Adapter: add gvlid in spec

* FreeWheel SSP Adapter: update code for site.content

* FreeWheel SSP Adapter: code update

* FreeWheel SSP Adapter: code update

* FreeWheel SSP Adapter: code update

* FreeWheel SSP Adapter: code update

* FreeWheel SSP Adapter: public vastXml in bidResponse for all media types
* added DocereeAdManager bid Adapter

* adapter prod api added

* new configs added

* md file changes

* double quotes to singlequotes

* removed unwanted code

* empty commit

* bidder name lower cased and few configs added

* md file changes

* spec file changes

* empty commit

* empty commit

* issues resolved

* empty commit

* issue fixes

* minor change

* empty commit

* minor change

* empty commit

* conditional changes

* removed unwanted code

---------

Co-authored-by: sagar4596 <132884303+sagar4596@users.noreply.github.com>
…tions (prebid#10675)

Co-authored-by: hongxingp <hongxingp@opera.com>
* get userId and userIdasEids if exist

* unit tests updated and refactor
@Jakeii Jakeii requested a review from a team as a code owner November 23, 2023 15:40
@@ -12,7 +12,6 @@
"ozoneBidAdapter",
"permutiveRtdProvider",
"prebidServerBidAdapter",
"pubCommonId",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module was deprecated and removed here prebid#9869 I'm not sure if we use it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Amouzle confirmed this module is no longer required

Copy link
Member

@arelra arelra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Jakeii !

@Jakeii Jakeii merged commit ee7f43c into main Dec 5, 2023
@Jakeii Jakeii deleted the jlk/v8.24.0-upgrade branch December 5, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment