33Across Analytics Adapter: initial release #10635
Conversation
- Single responsibility for transaction manager - Send one report per auction - Clear pending events that were causing conflicts in specs
…, refactoring, fix tests
…auctionEnd (in the case that auction ends AND not all bids have resolved), and general refactoring
…id,data.pbadslot}" values are both missing
Ticket: IDG-677
…tead of GAM ad unit code. Resolves IDG-1163.
…_matching IDG-1163:: Improve slotRenderEnded Matching
…ng existing customers forAnalytics.
|
I've sync'ed from the latest upstream main branch. Let me know if anything else is needed. |
|
@jlquaccia - Can you please review this pull request when you have a chance? |
|
Thanks, @jlquaccia! Feel free to merge at your earliest convenience. |
|
Hey @macinjosh32, apologies for overlooking this the other day, but looks like there are a few tests that are failing (flagged from the circleci build above). Could you address these? Then this PR should be good to go! |
|
@jlquaccia - I found the issue and fixed it, and all tests are passing when I run "npm run test" locally. However, when I push the fix and Prebid.js's CI runs, the BrowserStack testing fails on older Safari browsers due to a connection issue. I think the connection issue is unrelated to this pull request because CI is also failing on prebid:master with a similar error. I wanted to try re-running the CI, but it looks like write access is required for that. Can you please give it a try? |
|
@jlquaccia any updates on this? Let me know if there's anything I can do to help |
|
@macinjosh32 @mscottnelson sorry for the delay, wanted to confirm with another Prebid member that the failed test was something unrelated as suspected above and turns out it is unrelated. Re-ran the tests just now and everything passed. All good to go, will merge! |
|
Not a problem, and thank you! |
Type of change
Bugfix
Feature
New Analytics adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
The debut of a new Prebid Analytics Adapter from 33Across.
Other information
Documentation PR: prebid/prebid.github.io#4944