Skip to content
This repository was archived by the owner on Mar 29, 2023. It is now read-only.

Update repo to work with Terraform 0.13.x #51

Merged
merged 7 commits into from
Nov 24, 2020
Merged

Update repo to work with Terraform 0.13.x #51

merged 7 commits into from
Nov 24, 2020

Conversation

@robmorgan
Copy link
Contributor

@robmorgan robmorgan commented Nov 12, 2020 •
edited
Loading

  1. Update CircleCI to use Terraform 0.13.x.
  2. Upgraded the Google Providers to 3.43.0.
  3. Dropped GAE configuration options.
  4. Update the version constraint on all examples to require at least 0.12.26.
  5. Update pre-commit hooks to add gofmt.
  6. Upgrade the tests to support Terratest v0.30.23

In general, TF 0.13.x seems backwards compatible from a testing perspective: I did not need to change anything in modules in this PR.

@robmorgan robmorgan mentioned this pull request Nov 12, 2020
Merged
@robmorgan robmorgan changed the title Update repo to work with Terraform 0.13.x [WIP] Update repo to work with Terraform 0.13.x Nov 12, 2020
@robmorgan
Copy link
Contributor Author

robmorgan commented Nov 12, 2020

Builds are currently failing.

@robmorgan
Copy link
Contributor Author

robmorgan commented Nov 13, 2020

Tests passed in https://app.circleci.com/pipelines/github/gruntwork-io/terraform-google-sql/93/workflows/3c5acbbd-765b-4a27-b9c4-3057e920c6eb/jobs/191

@robmorgan robmorgan changed the title [WIP] Update repo to work with Terraform 0.13.x Update repo to work with Terraform 0.13.x Nov 13, 2020
brikis98
brikis98 approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robmorgan
Copy link
Contributor Author

robmorgan commented Nov 13, 2020

@brikis98 thanks for the review. I'll release next week!

@robmorgan robmorgan merged commit e258f14 into master Nov 24, 2020
@robmorgan robmorgan deleted the tf13 branch November 24, 2020 02:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yorinasub17 yorinasub17 Awaiting requested review from yorinasub17

1 more reviewer

@brikis98 brikis98 brikis98 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@robmorgan @brikis98