Add point in time recovery option in backend configuration #50
Conversation
|
Hey @mvoitko, Thanks for your contribution. How did you test this? |
|
hey @robmorgan/ I have tested the fix by deploying postgresql db with my fix. When I have done the same without my fix, the option is ignored. |
|
@mvoitko ok LGTM. I've kicked off the tests in: https://app.circleci.com/pipelines/github/gruntwork-io/terraform-google-sql/91/workflows/6b513bf2-0130-44e9-8ba4-2778b7655466 |
|
Note: This might need the updated Google provider in #51 to work correctly. |
|
@robmorgan thanks. Will fix the tests to pass on CircleCI and update providers |
mvoitko
force-pushed
the
feature/add-postgres-point-in-time-recovery-backup-config
branch
3 times, most recently
from
f1d7314 to
357d887
Compare
mvoitko
force-pushed
the
feature/add-postgres-point-in-time-recovery-backup-config
branch
from
357d887 to
1fa7a5a
Compare
|
@robmorgan Hi, I have updated the PR and rebased the latest master. Could you please review and trigger tests on CI? |
|
Hi @mvoitko, I'm happy to test your PR, but just scanning the code quickly, it seems you will need to swap your condition statement around. See https://github.com/gruntwork-io/terraform-google-sql/pull/50/files#diff-ae9c8fa94b8488ac9aa4da95f1c19d805e75292969cc372d0925f10e0532640aR79 - I believe this logic would apply to MySQL instead of Postgres. |
|
@robmorgan fixed |
|
@mvoitko thanks, I plan to release this on Friday. |
2 participants
No description provided.