Add benchmarks for Metadata collection #1691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Oct 30, 2023
Performance/Benchmarks/Benchmarks/GRPCSwiftBenchmark/Benchmarks.swift
Outdated
Show resolved
Hide resolved
Performance/Benchmarks/Benchmarks/GRPCSwiftBenchmark/Benchmarks.swift
Outdated
Show resolved
Hide resolved
dnadoba
reviewed
Oct 30, 2023
Comment on lines
59
to
54
| Benchmark("Metadata - Add binary") { benchmark in | ||
| let value: [UInt8] = [1, 2, 3] | ||
| benchmark.startMeasurement() | ||
| for _ in benchmark.scaledIterations { | ||
| var metadata = Metadata() | ||
| for i in 0..<1000 { | ||
| metadata.addBinary(value, forKey: "\(i)") | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Benchmark.init has an overload with a trailing setup closure which is executed once and can return some setup data: https://swiftpackageindex.com/ordo-one/package-benchmark/1.11.2/documentation/benchmark/benchmark/init(_:configuration:closure:setup:teardown:)-8kbjd
gjcairo
force-pushed
the
metadata-benchmarks
branch
2 times, most recently
from
e277bf2 to
9a5e91e
Compare
gjcairo
force-pushed
the
metadata-benchmarks
branch
from
9a5e91e to
583df4b
Compare
glbrntt
reviewed
Nov 1, 2023
| } | ||
| } | ||
|
|
||
| Benchmark("Metadata_Remove_values_for_key") { benchmark in |
There was a problem hiding this comment.
Seems like we only need underscores in the filename:
- https://github.com/apple/swift-certificates/blob/main/Benchmarks/Benchmarks/CertificatesBenchmark/Benchmarks.swift
- https://github.com/apple/swift-certificates/tree/main/Benchmarks/Thresholds/5.9
Can we remove them here?
There was a problem hiding this comment.
This is what I had originally (files with underscores, benchmark names with spaces) but the check against the thresholds would always pass even when it shouldn't - I could only make it fail once I started using underscores in the names too.
glbrntt
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds benchmarks (perf tests) for the Metadata collection introduced in #1683
Modifications
Benchmarks added
Result
Benchmarks for Metadata collection are now present.