Add Metadata collection #1683
Merged
Add Metadata collection #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
force-pushed
the
metadata-collection
branch
2 times, most recently
from
e1fd59e
to
e8ad94f
Compare
gjcairo
force-pushed
the
metadata-collection
branch
2 times, most recently
from
c782124
to
a422f61
Compare
glbrntt
requested changes
Oct 26, 2023
FranzBusch
reviewed
Oct 26, 2023
There was a problem hiding this comment.
This looks great overall. Really love the new expressivity for metadata here! Not sure if we should do it in this PR or a follow up but we should have benchmarks for adding/removing/iterating the Metadata. I can already see some methods on the various RandomAccessColllection/Sequence types that are prone to allocate due to missing @inlinable on them.
It might be good to start adding perf benchmarks right away with our new v2 code instead of after the fact. WDYT @glbrntt ?
Look at radar ;) |
gjcairo
force-pushed
the
metadata-collection
branch
from
8d287ad
to
cb0acc3
Compare
gjcairo
force-pushed
the
metadata-collection
branch
3 times, most recently
from
354a195
to
1c30ad2
Compare
gjcairo
force-pushed
the
metadata-collection
branch
from
1c30ad2
to
382579f
Compare
glbrntt
requested changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds a new Metadata collection for gRPC Core. This collection has the following requirements:
Modifications
Implemented a new
Metadatacollection that follows the above requirements.Result
Metadata collection is available.