HTTP CONNECT: handle early server packets #2746
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
This change looks good, but I can't merge it until you sign the CLA. |
Contributor
Author
|
I know. I'm waiting for legal department. |
Contributor
Author
|
@murgatroid99 CLA unblocked! The test failure on Windows seems unrelated. |
Member
|
This is now out in version 1.10.10. |
This was referenced Jul 24, 2024
This was referenced Aug 16, 2024
This was referenced Sep 1, 2024
This was referenced Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an HTTP CONNECT proxy, it is possible for the server's first HTTP2 packet to reach the client before the node's HTTP library even starts parsing the HTTP
HTTP/1.1 200 Connectedresponse.When that happens, node's HTTP response parser may take these extra bytes (i.e. the server's first HTTP2 packets) out of the socket into its parsing buffer. That means that these extra bytes will not be emitted through the tunneled socket provided on the
connectevent. Instead, these extra bytes are provided through theheadparameter of theconnectevent.This PR reinjects these extra bytes (if any) into the tunneled socket.
Fixes #2744.