Skip to content

fix: add decoding for url encoded user credentials #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
murgatroid99 merged 1 commit into from
Jun 18, 2024
Merged

fix: add decoding for url encoded user credentials #2761

murgatroid99 merged 1 commit into from
Jun 18, 2024

Conversation

@brendan-myers
Copy link
Contributor

@brendan-myers brendan-myers commented May 29, 2024

Added support for URL encoded user credentials.

Previously, if a username/password contained a special character that required encoding, eg grpc_proxy=http://user%40example.com:password@127.0.0.1:8888, then the connection would be rejected (40x).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: brendan-myers / name: Brendan Myers (8e2dc27)

@murgatroid99 murgatroid99 merged commit c447875 into grpc:master Jun 18, 2024
murgatroid99 added a commit that referenced this pull request Jun 24, 2024
@murgatroid99
Merge pull request #2777 from murgatroid99/grpc-js_1.10_backports
3c55b5b 
Backport #2746 and #2761 to 1.10.x
@murgatroid99
Copy link
Member

murgatroid99 commented Jun 24, 2024

This is now out in version 1.10.10.

@thiswayman thiswayman mentioned this pull request Jul 16, 2024
Open
@MrRaja23 MrRaja23 mentioned this pull request Jul 17, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 17, 2024
Open
@DevMockSec DevMockSec mentioned this pull request Jul 17, 2024
Open
@Gal-Doron Gal-Doron mentioned this pull request Jul 17, 2024
Open
@thiswayman thiswayman mentioned this pull request Jul 17, 2024
Open
@j-mendez j-mendez mentioned this pull request Jul 17, 2024
Open
@virender-rathore-ml virender-rathore-ml mentioned this pull request Jul 18, 2024
Open
@vroldanbet vroldanbet mentioned this pull request Jul 18, 2024
Closed
@Elenore23 Elenore23 mentioned this pull request Jul 21, 2024
Open
@harshakrithvikk harshakrithvikk mentioned this pull request Jul 24, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 24, 2024
Open
@vroldanbet vroldanbet mentioned this pull request Jul 24, 2024
Closed
@thiswayman thiswayman mentioned this pull request Jul 24, 2024
Open
This was referenced Jul 24, 2024
Open
Open
@vroldanbet vroldanbet mentioned this pull request Jul 29, 2024
Closed
@thiswayman thiswayman mentioned this pull request Jul 29, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Jul 30, 2024
Open
@MrRaja23 MrRaja23 mentioned this pull request Aug 7, 2024
Open
@thiswayman thiswayman mentioned this pull request Aug 7, 2024
Open
@j-mendez j-mendez mentioned this pull request Aug 7, 2024
Open
@tweiss9 tweiss9 mentioned this pull request Aug 7, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 10, 2024
Open
@thiswayman thiswayman mentioned this pull request Aug 10, 2024
Open
@Isuf-Muca Isuf-Muca mentioned this pull request Aug 10, 2024
Open
@thiswayman thiswayman mentioned this pull request Aug 15, 2024
Open
This was referenced Aug 16, 2024
Open
Open
@thiswayman thiswayman mentioned this pull request Aug 17, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 19, 2024
Open
@thiswayman thiswayman mentioned this pull request Aug 19, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 20, 2024
Open
@thiswayman thiswayman mentioned this pull request Aug 20, 2024
Open
@vroldanbet vroldanbet mentioned this pull request Aug 20, 2024
Closed
@thiswayman thiswayman mentioned this pull request Aug 21, 2024
Open
@vroldanbet vroldanbet mentioned this pull request Aug 21, 2024
Closed
@davehorton davehorton mentioned this pull request Aug 21, 2024
Open
@MrRaja23 MrRaja23 mentioned this pull request Aug 21, 2024
Open
@thiswayman thiswayman mentioned this pull request Aug 21, 2024
Open
@vroldanbet vroldanbet mentioned this pull request Aug 22, 2024
Closed
@MrRaja23 MrRaja23 mentioned this pull request Aug 22, 2024
Open
@thiswayman thiswayman mentioned this pull request Aug 23, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request Aug 28, 2024
Open
@thiswayman thiswayman mentioned this pull request Aug 28, 2024
Open
@searce-nirav searce-nirav mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 1, 2024
Open
Open
This was referenced Sep 2, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brendan-myers @murgatroid99 @kokoro-team