Skip to content

Conversation

@zpencer
Copy link
Contributor

@zpencer zpencer commented Jun 30, 2017

For basicStream, we can not use a timeout with the inOrder mock. The test looks like it's only testing for one interaction in that part of the test, rather than multiple interactions in a specific order. This looks fine to me. Please let me know what you think.

clientCancelFromWithinMessageRead is another test that needs a timeout argument.

@zpencer zpencer requested a review from zhangkun83 June 30, 2017 22:46
@zpencer zpencer merged commit e14fc40 into grpc:master Jul 18, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants