Skip to content

Commit e14fc40

Browse files
authored
netty: add timeouts to address test flakiness (#3169)
This test is sometimes flakey
1 parent 6ea2b8a commit e14fc40

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

testing/src/main/java/io/grpc/internal/testing/AbstractTransportTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ public void basicStream() throws Exception {
646646
StreamCreation serverStreamCreation
647647
= serverTransportListener.takeStreamOrFail(TIMEOUT_MS, TimeUnit.MILLISECONDS);
648648
if (metricsExpected()) {
649-
clientInOrder.verify(clientStreamTracer).outboundHeaders();
649+
verify(clientStreamTracer, timeout(TIMEOUT_MS)).outboundHeaders();
650650
}
651651
assertEquals(methodDescriptor.getFullMethodName(), serverStreamCreation.method);
652652
assertEquals(Lists.newArrayList(clientHeadersCopy.getAll(asciiKey)),
@@ -1033,7 +1033,7 @@ public void onReady() {
10331033
verify(serverStreamTracer, atLeast(1)).outboundUncompressedSize(anyLong());
10341034
// There is a race between client cancelling and server closing. The final status seen by the
10351035
// server is non-deterministic.
1036-
verify(serverStreamTracer).streamClosed(any(Status.class));
1036+
verify(serverStreamTracer, timeout(TIMEOUT_MS)).streamClosed(any(Status.class));
10371037
verifyNoMoreInteractions(clientStreamTracer);
10381038
verifyNoMoreInteractions(serverStreamTracer);
10391039
}

0 commit comments

Comments
 (0)