*:Add terminating newline to README.md #7639
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7639 +/- ##
==========================================
- Coverage 81.90% 81.88% -0.03%
==========================================
Files 361 361
Lines 27816 27816
==========================================
- Hits 22784 22778 -6
- Misses 3841 3844 +3
- Partials 1191 1194 +3 |
purnesh42H
reviewed
Sep 17, 2024
| ``` |
There was a problem hiding this comment.
new line should be after quotes before eof
There was a problem hiding this comment.
It is after the quotes. Its just how the difference shows up because there is nothing in newline.
arjan-bal
approved these changes
Sep 17, 2024
|
Adding the screenshot for clarification: |
purnesh42H
approved these changes
Sep 17, 2024
|
nit: you have an unintended commit in your PR. May be its better to create a fresh branch? |
|
Defer to #7644 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add terminating newline to README.md files.
RELEASE NOTES: None