Waiting for the reader GO routine to end in conn.close()

eshitachandwani · eshitachandwani · commit 79da4fb4dd95 · 2024-09-16T12:05:12.000+05:30
diff --git a/internal/transport/http2_client.go b/internal/transport/http2_client.go
@@ -1023,6 +1023,7 @@ func (t *http2Client) Close(err error) {
 	case <-timer.C:
 		t.logger.Infof("Failed to write a GOAWAY frame as part of connection close after %s. Giving up and closing the transport.", goAwayLoopyWriterTimeout)
 	}
+	<-t.readerDone
 	t.cancel()
 	t.conn.Close()
 	channelz.RemoveEntry(t.channelz.ID)

Original file line number	Diff line number	Diff line change
`@@ -1023,6 +1023,7 @@ func (t *http2Client) Close(err error) {`
`1023`	`1023`	`case <-timer.C:`
`1024`	`1024`	`t.logger.Infof("Failed to write a GOAWAY frame as part of connection close after %s. Giving up and closing the transport.", goAwayLoopyWriterTimeout)`
`1025`	`1025`	`}`
	`1026`	`+ <-t.readerDone`
`1026`	`1027`	`t.cancel()`
`1027`	`1028`	`t.conn.Close()`
`1028`	`1029`	`channelz.RemoveEntry(t.channelz.ID)`