Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base64.URLEncoding for []byte parameters in query #1978

Conversation

tvoll
Copy link
Contributor

@tvoll tvoll commented Feb 17, 2021

Changes encoding method to base64.URLEncoding for query parameters of type []byte.

@google-cla
Copy link

google-cla bot commented Feb 17, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 17, 2021
@johanbrandhorst
Copy link
Collaborator

Hi, please rebase on master, we've changed our generation strategy quite a bit with #1971.

@johanbrandhorst
Copy link
Collaborator

Hi, this change looks great to me, thanks for your contribution. Can you please sign the CLA?

@tvoll tvoll force-pushed the fix-url-encoded-bytes-as-url-parameters branch from a9bcd3b to 183e1e7 Compare February 18, 2021 09:33
@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 18, 2021
@tvoll
Copy link
Contributor Author

tvoll commented Feb 18, 2021

@googlebot I signed it!

@johanbrandhorst johanbrandhorst merged commit 62529fa into grpc-ecosystem:master Feb 18, 2021
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@tvoll
Copy link
Contributor Author

tvoll commented Feb 19, 2021

@johanbrandhorst Thank you for all of your work! I'm still blown away by what you can achieve with gRPC transcoding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants