Migrate generation, linting to buf #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
force-pushed
the
add-buf-yaml
branch
7 times, most recently
from
ce31064 to
483bbd3
Compare
johanbrandhorst
commented
Feb 14, 2021
| RUN wget https://github.com/google/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-linux-x86_64.zip \ | ||
| -O /protoc-${PROTOC_VERSION}-linux-x86_64.zip && \ | ||
| unzip /protoc-${PROTOC_VERSION}-linux-x86_64.zip -d /usr/local/ && \ | ||
| rm -f /protoc-${PROTOC_VERSION}-linux-x86_64.zip |
There was a problem hiding this comment.
🎉. This change isn't effective as of this PR, it will be the next time we push the docker image.
johanbrandhorst
commented
Feb 14, 2021
johanbrandhorst
commented
Feb 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #1971 +/- ##
=======================================
Coverage 58.09% 58.09%
=======================================
Files 34 34
Lines 3780 3780
=======================================
Hits 2196 2196
Misses 1313 1313
Partials 271 271 Continue to review full report at Codecov.
|
johanbrandhorst
commented
Feb 14, 2021
johanbrandhorst
force-pushed
the
add-buf-yaml
branch
2 times, most recently
from
a8f2d69 to
c1fa40a
Compare
adambabik
reviewed
Feb 15, 2021
johanbrandhorst
force-pushed
the
add-buf-yaml
branch
2 times, most recently
from
42d135c to
2d17900
Compare
johanbrandhorst
commented
Feb 15, 2021
johanbrandhorst
force-pushed
the
add-buf-yaml
branch
2 times, most recently
from
4d184c8 to
640adf0
Compare
adambabik
approved these changes
Feb 17, 2021
Migrate to buf for generation, linting and breaking change detection. Removes much of the complicated Makefile logic and the need for protoc in favour of buf generate.
This is no longer needed since we can depend on googleapis from the BSR
The generated, hidden bazel directory will mess up buf's generation if it exists, so we ignore it.
johanbrandhorst
force-pushed
the
add-buf-yaml
branch
from
640adf0 to
b6abc29
Compare
This was referenced Feb 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to buf for generation, linting and breaking change detection. Removes much of the complicated Makefile logic and the need for protoc in favour of buf generate.
Adds a CI step to push new versions to the BSR.