Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: In retry package, pass context to custom retry handler #171

Closed
johanbrandhorst opened this issue Nov 9, 2018 · 0 comments
Closed

FR: In retry package, pass context to custom retry handler #171

johanbrandhorst opened this issue Nov 9, 2018 · 0 comments

Comments

@johanbrandhorst
Copy link
Collaborator

johanbrandhorst commented Nov 9, 2018 •
edited
Loading

Much like #168, the function used to configure the retry interval should take provide a context for access to request scoped variables such as OpenCensus tags.

This will likely require the introduction of a new type and function for configuration in order to stay backwards compatible.
johanbrandhorst added a commit to johanbrandhorst/go-grpc-middleware that referenced this issue Nov 9, 2018
@johanbrandhorst
recovery: add new BackoffFuncContext type
76d68eb 
BackoffFuncContext adds the context parameter, allowing
the retry function access to the contents of the parent
context.

Fixes grpc-ecosystem#171
johanbrandhorst added a commit to johanbrandhorst/go-grpc-middleware that referenced this issue Nov 9, 2018
@johanbrandhorst
retry: add new BackoffFuncContext type
8db4998 
BackoffFuncContext adds the context parameter, allowing
the retry function access to the contents of the parent
context.

Fixes grpc-ecosystem#171
@johanbrandhorst johanbrandhorst mentioned this issue Nov 9, 2018
Merged
johanbrandhorst added a commit to johanbrandhorst/go-grpc-middleware that referenced this issue Nov 9, 2018
@johanbrandhorst
retry: add new BackoffFuncContext type
29e1709 
BackoffFuncContext adds the context parameter, allowing
the retry function access to the contents of the parent
context.

Fixes grpc-ecosystem#171
domgreen pushed a commit that referenced this issue Nov 12, 2018
@johanbrandhorst @domgreen
Add context functions to retry and recover (#172)
3304cc8 
* retry: add new BackoffFuncContext type

BackoffFuncContext adds the context parameter, allowing
the retry function access to the contents of the parent
context.

Fixes #171

* recovery: add new RecoveryHandlerFuncContext type

Allows the user to configure a custom recovery handler
that has access to the request scoped values in the
context.

Fixes #168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johanbrandhorst