Add context functions to retry and recover #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
commented
Nov 9, 2018
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
- Coverage 73.47% 72.91% -0.57%
==========================================
Files 36 36
Lines 1327 1340 +13
==========================================
+ Hits 975 977 +2
- Misses 303 314 +11
Partials 49 49
Continue to review full report at Codecov.
|
bwplotka
approved these changes
Nov 9, 2018
BackoffFuncContext adds the context parameter, allowing the retry function access to the contents of the parent context. Fixes grpc-ecosystem#171
Allows the user to configure a custom recovery handler that has access to the request scoped values in the context. Fixes grpc-ecosystem#168
johanbrandhorst
force-pushed
the
add-context-retry-recovery-parameters
branch
from
a39880c
to
f29882f
Compare
|
Bump @domgreen 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #168
Fixes #171