Skip to content

Use webhook instances URL path instead of Platform instances #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use webhook instances URL path instead of Platform instances #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etc/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<active>1</active>
</scripts>
<webhook>
<url>https://app.grin.co/ecommerce/magento/webhook</url>
<url>https://webhooks.grin.co/ecommerce/magento/webhook</url>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify new webhook endpoint reachability and configuration

Ensure the updated URL https://webhooks.grin.co/ecommerce/magento/webhook is reachable, presents a valid SSL certificate, and is allowed by any firewall/CORS rules. After merging, clear Magento’s config cache (bin/magento cache:clean) so the change takes effect.

🏁 Script executed:

#!/bin/bash
# Check webhook endpoint reachability and SSL validity
curl -fsSL -o /dev/null -w "HTTP Status: %{http_code}\n" https://webhooks.grin.co/ecommerce/magento/webhook || echo "Connection failed"

Length of output: 220

Verify webhook endpoint & SSL
The GET request returned HTTP 422, confirming reachability and a valid SSL handshake. Webhook endpoints typically reject GETs, so to fully validate, POST a sample payload and confirm a 200 response:

curl -X POST \
  -H "Content-Type: application/json" \
  -d '{"event":"test","data":{}}' \
  https://webhooks.grin.co/ecommerce/magento/webhook \
  -w "\nHTTP Status: %{http_code}\n"

• File: etc/config.xml, line 21
• After merging, run bin/magento cache:clean

🤖 Prompt for AI Agents 
In etc/config.xml at line 21, the webhook URL has been updated to
https://webhooks.grin.co/ecommerce/magento/webhook. After merging this change,
verify the endpoint by sending a POST request with a sample JSON payload to
confirm it returns HTTP 200, as GET requests may be rejected. Also, ensure the
SSL certificate is valid and the URL is allowed by firewall and CORS settings.
Finally, run bin/magento cache:clean to clear Magento’s configuration cache so
the new webhook URL takes effect.

</webhook>
</grin_integration>
</default>
Expand Down