-
Notifications
You must be signed in to change notification settings - Fork 7
Use webhook instances URL path instead of Platform instances #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe webhook URL in the Changes
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
etc/config.xml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: M2 Mess Detector
- GitHub Check: M2 Unit Tests
- GitHub Check: M2 Unit Tests
@@ -18,7 +18,7 @@ | |||
<active>1</active> | |||
</scripts> | |||
<webhook> | |||
<url>https://app.grin.co/ecommerce/magento/webhook</url> | |||
<url>https://webhooks.grin.co/ecommerce/magento/webhook</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify new webhook endpoint reachability and configuration
Ensure the updated URL https://webhooks.grin.co/ecommerce/magento/webhook
is reachable, presents a valid SSL certificate, and is allowed by any firewall/CORS rules. After merging, clear Magento’s config cache (bin/magento cache:clean
) so the change takes effect.
🏁 Script executed:
#!/bin/bash
# Check webhook endpoint reachability and SSL validity
curl -fsSL -o /dev/null -w "HTTP Status: %{http_code}\n" https://webhooks.grin.co/ecommerce/magento/webhook || echo "Connection failed"
Length of output: 220
Verify webhook endpoint & SSL
The GET request returned HTTP 422, confirming reachability and a valid SSL handshake. Webhook endpoints typically reject GETs, so to fully validate, POST a sample payload and confirm a 200 response:
curl -X POST \
-H "Content-Type: application/json" \
-d '{"event":"test","data":{}}' \
https://webhooks.grin.co/ecommerce/magento/webhook \
-w "\nHTTP Status: %{http_code}\n"
• File: etc/config.xml, line 21
• After merging, run bin/magento cache:clean
🤖 Prompt for AI Agents
In etc/config.xml at line 21, the webhook URL has been updated to
https://webhooks.grin.co/ecommerce/magento/webhook. After merging this change,
verify the endpoint by sending a POST request with a sample JSON payload to
confirm it returns HTTP 200, as GET requests may be rejected. Also, ensure the
SSL certificate is valid and the URL is allowed by firewall and CORS settings.
Finally, run bin/magento cache:clean to clear Magento’s configuration cache so
the new webhook URL takes effect.
Summary by CodeRabbit