Repository navigation
fix to animate - #1395
Merged
Merged
fix to animate#1395
Conversation
* fix for gridstack#937, thank you @marttop for proposing a fix * ended up re-writting the CSS creation routine and make it easier to maintain going forward. * we now only re-create stylesheet when margin or cellHeight (the only static items) change. Else we happen row based rules as the grids needs them (and only what it needs, not always +10)
|
Thanks for this final fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Else we append row based rules as the grids needs them (and only what it needs, not always +10)
(the old code would delete and re-create the sheet just about every time (at least twice on startup + 1 for every row as +10 buffer was always added, no a buffer per say...)
Checklist
yarn test)