Repository navigation
Conversation
Member
|
thanks for taking a second look. I think I want to re-write this all thing rather than try to patch what's there... but I need to understand all corner cases first. We also should delete the style when destroy() happens (which we don't) so we need a separate removeStyle() method that will also reset the max info structure... Probably best to let me do it at this point. I'm tied this weekend but might get to it middle of next week. |
Author
|
I understand that you want to rewrite it, but just in case, this at least fixes the bug temporarily. |
Member
|
thank you for fix suggestion! I ended up re-writing that code instead #1395 AND default to animate since SO much nicer (I even didn't know about it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#937 Fixing this issue by not recreating the stylesheet.
#1391 I created another pull request (It's for sure not the proper way to do but I still struggle a lot with git) and followed @adumesny's advices :
For cellHeigh() and margin(), on method _updateStyles I added a boolean parameter 'doForceUpdate' witch is set to true only when called from cellHeight() or margin(). In that case I reset the stylesheet.
Checklist
yarn test)