Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small edits #6

Merged
merged 11 commits into from
May 11, 2024
Merged

small edits #6

merged 11 commits into from
May 11, 2024

Conversation

svecs132
Copy link
Collaborator

@svecs132 svecs132 commented May 8, 2024

this is gonna be an incremental list of commits I create as I get more and more familiar with WPF (this is my first time working with it 😅) and this repository

@svecs132
Copy link
Collaborator Author

svecs132 commented May 8, 2024

@greyshirtguy can you please look at these commits occasionally and give me some feedback?

thanks

svecs132 added 6 commits May 8, 2024 22:02
1. the Chords versions no longer show up in the list, disallowing you to edit them and get Chords Chords versions etc.
2. when loading a presentation, the program checks if there exists a Chords version of that presentation and if so, loads it instead, basically keeping your progress
@svecs132
Copy link
Collaborator Author

@greyshirtguy what do you think about these changes?

@svecs132 svecs132 marked this pull request as ready for review May 10, 2024 13:23
@svecs132
Copy link
Collaborator Author

I would assign you this PR for review but I don't have the permission to do so 😅

@greyshirtguy
Copy link
Owner

greyshirtguy commented May 11, 2024

You have the power!!!
image

Since you have shown more interest and gumption than me (and this was just a "non-serious rush experiment") - you should "Go to town" with your ideas!... Try not to break it! ;)

My only ask/suggestion:
Compile and TEST your changes LOTS! - Spend the time to do lots of tests (eg an hour of testing all functions in the app for any major code changes)

Test a bunch of typical use cases.....also try to break the app when you make changes!

@svecs132
Copy link
Collaborator Author

yeah that's what I've been doing after every change

also thanks for the permissions!

@svecs132 svecs132 merged commit 792c1cb into greyshirtguy:master May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants