Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to update NVTs via OSP #392

Merged
merged 29 commits into from
May 23, 2019
Merged

Add option to update NVTs via OSP #392

merged 29 commits into from
May 23, 2019

Conversation

mattmundell
Copy link
Contributor

No description provided.

@mattmundell mattmundell added the work in progress This pull request should not be merged yet, more commits are expected label Feb 11, 2019
@mattmundell mattmundell requested review from a team and removed request for a team February 11, 2019 12:09
@mattmundell
Copy link
Contributor Author

Requires greenbone/gvm-libs#188

@mattmundell mattmundell removed the work in progress This pull request should not be merged yet, more commits are expected label Mar 5, 2019
@mattmundell mattmundell requested a review from a team March 5, 2019 16:48
@mattmundell mattmundell added the work in progress This pull request should not be merged yet, more commits are expected label Mar 18, 2019
@mattmundell mattmundell removed the work in progress This pull request should not be merged yet, more commits are expected label May 19, 2019
@mattmundell
Copy link
Contributor Author

Now updates NVT preferences too. ospd-openvas is messing up the values in
the VT params, but I think it's correct on Manager side.

Also, the OSP NVT update does not do chunking like the OTP update does, but
that can come in a later PR. Combining INSERTs would also be good.

jjnicola
jjnicola suggested changes May 22, 2019
View reviewed changes
src/manage_sql_nvts.c Outdated Show resolved Hide resolved
jjnicola
jjnicola reviewed May 22, 2019
View reviewed changes
src/manage_sql_nvts.c Outdated Show resolved Hide resolved
@mattmundell mattmundell requested review from jjnicola and removed request for janowagner and timopollmeier May 23, 2019 13:13
@jjnicola
Copy link
Member

Hi @mattmundell, I tried it again with the last changes and the nvt update works as expected. I can see now the preferences without a default value. Also it is able to recognize a new feed version.

@mattmundell mattmundell merged commit 46dd903 into greenbone:master May 23, 2019
@mattmundell mattmundell deleted the nvt-rebuild-via-osp branch May 23, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjnicola jjnicola jjnicola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @jjnicola