Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OSP functions for getting VTs #188

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Add OSP functions for getting VTs #188

merged 2 commits into from
Mar 1, 2019

Conversation

mattmundell
Copy link
Contributor

No description provided.

@mattmundell mattmundell added the work in progress This pull request should not be merged yet, more commits are expected label Feb 11, 2019
@mattmundell mattmundell requested review from a team and removed request for a team February 11, 2019 12:10
@mattmundell mattmundell mentioned this pull request Feb 11, 2019
Merged
@mattmundell mattmundell removed the work in progress This pull request should not be merged yet, more commits are expected label Feb 25, 2019
@mattmundell mattmundell requested a review from a team February 25, 2019 11:18
janowagner
janowagner approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@janowagner janowagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense in general.

Only I saw a wrong doc: "vtss" probably should be "vts".

@mattmundell mattmundell merged commit b069b0d into greenbone:master Mar 1, 2019
@mattmundell mattmundell deleted the osp-get-vts branch March 1, 2019 15:24
@mattmundell
Copy link
Contributor Author

Oh shoot forgot the doc. Will make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janowagner janowagner janowagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmundell @janowagner