Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated sys_siglist with strsignal #1280

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Replace deprecated sys_siglist with strsignal #1280

merged 1 commit into from
Sep 1, 2020

Conversation

tgurr
Copy link
Contributor

@tgurr tgurr commented Aug 31, 2020

Required to work with glibc >= 2.32.

https://sourceware.org/pipermail/libc-announce/2020/000029.html

The deprecated arrays sys_siglist, _sys_siglist, and sys_sigabbrev
are no longer available to newly linked binaries, and their declarations
have been removed from <string.h>. They are exported solely as
compatibility symbols to support old binaries. All programs should use
strsignal instead.

What: N/A

Why: #1279

How: N/A

Checklist:

@mattmundell mattmundell changed the base branch from master to gvmd-20.08 August 31, 2020 16:21
@mattmundell mattmundell changed the base branch from gvmd-20.08 to master August 31, 2020 16:22
Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

If you want this in the next 20.08 release then please submit a PR against gvmd-20.08 instead.

And would be great if you could add a CHANGELOG.md entry.

@tgurr
Copy link
Contributor Author

tgurr commented Aug 31, 2020

If you want this in the next 20.08 release then please submit a PR against gvmd-20.08 instead.

I'll open a follow-up PR once this is through.

And would be great if you could add a CHANGELOG.md entry.

Added.

@mattmundell
Copy link
Contributor

If you want this in the next 20.08 release then please submit a PR against gvmd-20.08 instead.

I'll open a follow-up PR once this is through.

And would be great if you could add a CHANGELOG.md entry.

Added.

@mattmundell mattmundell reopened this Aug 31, 2020
@mattmundell
Copy link
Contributor

I'll open a follow-up PR once this is through.

I think just gvmd-20.08 would be easier, because we'll merge that to master.

@tgurr tgurr changed the base branch from master to gvmd-20.08 September 1, 2020 07:39
@tgurr
Copy link
Contributor Author

tgurr commented Sep 1, 2020

I'll open a follow-up PR once this is through.

I think just gvmd-20.08 would be easier, because we'll merge that to master.

Took me a moment to figure out, I hope I did everything correctly switching the PR to gvmd-20.08.

Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's great, thank you.

One nitpick left, just noticed the missing spaces.

src/gvmd.c Outdated Show resolved Hide resolved
src/gvmd.c Outdated Show resolved Hide resolved
src/manage_sql.c Show resolved Hide resolved
src/utils.c Outdated Show resolved Hide resolved
src/utils.c Outdated Show resolved Hide resolved
Required to work with glibc >= 2.32.

https://sourceware.org/pipermail/libc-announce/2020/000029.html

  The deprecated arrays sys_siglist, _sys_siglist, and sys_sigabbrev
  are no longer available to newly linked binaries, and their declarations
  have been removed from <string.h>. They are exported solely as
  compatibility symbols to support old binaries. All programs should use
  strsignal instead.
@mattmundell mattmundell self-requested a review September 1, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants