Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler error: may be used uninitialized in this function [-Werr… #398

Closed
wants to merge 3 commits into from

Conversation

tuxmaster5000
Copy link
Contributor

Fix for #397

Copy link
Contributor

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for this one. Can you make it against gvm-libs-20.08? Otherwise it will only be released in 21.04.

@tuxmaster5000 tuxmaster5000 changed the base branch from master to gvm-libs-20.08 September 1, 2020 12:04
@tuxmaster5000 tuxmaster5000 changed the base branch from gvm-libs-20.08 to master September 1, 2020 12:04
@tuxmaster5000 tuxmaster5000 changed the base branch from master to gvm-libs-20.08 September 1, 2020 12:08
@tuxmaster5000 tuxmaster5000 changed the base branch from gvm-libs-20.08 to master September 1, 2020 12:09
@tuxmaster5000
Copy link
Contributor Author

Also for this one. Can you make it against gvm-libs-20.08? Otherwise it will only be released in 21.04.

When I simple change the target branch then it will fail's because many other files will changed. :(

@mattmundell
Copy link
Contributor

When I simple change the target branch then it will fail's because many other files will changed. :(

Yes, I had the same problem on greenbone/gvmd#1280.

I"m not sure how the OP handled it. I guess by using a git rebase command on their local tree.

@bjoernricks
Copy link
Contributor

bjoernricks commented Sep 1, 2020

git --onto is your friend. See https://medium.com/@gabriellamedas/git-rebase-and-git-rebase-onto-a6a3f83f9cce for some details.

@tgurr
Copy link
Contributor

tgurr commented Sep 10, 2020

Since greenbone/gvmd#1280 has been mentioned, I took a small note back then because it also took me a while to figure it out, git --onto has already been mentioned which I had been using as well, here's what I did:

git checkout sys_siglist
git rebase --onto origin/upstream/gvmd-20.08 master
git rebase --continue
git push origin sys_siglist --force

@ArnoStiefvater ArnoStiefvater mentioned this pull request Feb 22, 2021
2 tasks
@tuxmaster5000 tuxmaster5000 requested a review from a team as a code owner June 28, 2021 14:03
@ArnoStiefvater
Copy link
Member

Thank you for contributing! It appears this fix was already applied to a different branch with #448 and merged some time later into 21.04 and master, therefore closing the PR.

@tuxmaster5000 tuxmaster5000 deleted the uninitialized branch July 1, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants