Skip to content

feat(daffio): convert all modules to standalone #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
damienwebdev merged 8 commits into from
Nov 26, 2025
Merged

feat(daffio): convert all modules to standalone #4215

damienwebdev merged 8 commits into from
Nov 26, 2025

Conversation

@xelaint
Copy link
Member

@xelaint xelaint commented Nov 25, 2025 •
edited
Loading

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #
Part of: #3971

New behavior

Breaking change?

  • Yes
  • No

Additional context

@xelaint xelaint requested a review from griest024 November 25, 2025 15:27
@xelaint xelaint requested review from a team as code owners November 25, 2025 15:27
@xelaint xelaint added the package: daff.io @daffodil/daff.io label Nov 25, 2025
damienwebdev
damienwebdev requested changes Nov 25, 2025
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is non-standard. We should instead make loadComponent lazy

I couldn't find any examples of current Angular docs using loadChildren

@damienwebdev
Copy link
Member

damienwebdev commented Nov 26, 2025

After re-reviewing this with @xelaint it looks like loadChildren can be used without NgModules, thought this isn't documented anywhere on Angular.dev.

@xelaint xelaint changed the title feat(daffio): convert routing modules to standalone routes feat(daffio): convert all modules to standalone Nov 26, 2025
@damienwebdev damienwebdev mentioned this pull request Nov 26, 2025
Closed
15 tasks
@xelaint
Copy link
Member Author

xelaint commented Nov 26, 2025

scrollOffset needs to be configured.

@damienwebdev
Copy link
Member

damienwebdev commented Nov 26, 2025

I found some bugs while deploying to vercel.

@damienwebdev damienwebdev requested a review from a team as a code owner November 26, 2025 20:03
damienwebdev
damienwebdev approved these changes Nov 26, 2025
View reviewed changes
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 99dc925 into develop Nov 26, 2025
63 checks passed
@damienwebdev damienwebdev deleted the feat/daffio-standalone branch November 26, 2025 20:30
@gray-bot gray-bot mentioned this pull request Nov 26, 2025
Merged
@damienwebdev damienwebdev mentioned this pull request Nov 26, 2025
Closed
10 tasks
@damienwebdev damienwebdev mentioned this pull request Dec 11, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damienwebdev damienwebdev damienwebdev approved these changes

@griest024 griest024 Awaiting requested review from griest024

Assignees

No one assigned

Labels

package: daff.io @daffodil/daff.io

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xelaint @damienwebdev