feat(GlobalScheduler): implement deferred removal of schedulers #136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition in scheduler iteration
The performUpdate() method iterates through scheduler arrays while scheduler callbacks can call removeScheduler(), which modifies the arrays in-place using splice(). This causes iteration to skip elements when a scheduler is removed during the loop:
Loop at index j=1, processing scheduler B
Scheduler B calls removeScheduler() for themself at index 1
Array shifts: [A,B,C,D] → [A,C,D], so C moves from index 2 to index 1
Loop increments to j=2, skipping scheduler C entirely
Fixed by implementing deferred removal - schedulers are marked for deletion during iteration and actually removed before the next update cycle.