feat(GlobalScheduler): implement deferred removal of schedulers (#136)

Author: Antamansid

src/lib/Scheduler.ts

@@ -19,6 +19,7 @@ export enum ESchedulerPriority {
 export class GlobalScheduler {
   private schedulers: [IScheduler[], IScheduler[], IScheduler[], IScheduler[], IScheduler[]];
   private _cAFID: number;
+  private toRemove: Array<[IScheduler, ESchedulerPriority]> = [];
 
   constructor() {
     this.tick = this.tick.bind(this);
@@ -36,11 +37,7 @@ export class GlobalScheduler {
   }
 
   public removeScheduler(scheduler: IScheduler, index = ESchedulerPriority.MEDIUM) {
-    const i = this.schedulers[index].indexOf(scheduler);
-
-    if (i !== -1) {
-      this.schedulers[index].splice(i, 1);
-    }
+    this.toRemove.push([scheduler, index]);
   }
 
   public start() {
@@ -70,6 +67,15 @@ export class GlobalScheduler {
         schedulers[j].performUpdate(getNow() - startTime);
       }
     }
+
+    // Process deferred removals after all schedulers have been executed
+    for (const [scheduler, index] of this.toRemove) {
+      const schedulerIndex = this.schedulers[index].indexOf(scheduler);
+      if (schedulerIndex !== -1) {
+        this.schedulers[index].splice(schedulerIndex, 1);
+      }
+    }
+    this.toRemove.length = 0;
   }
 }
 

src/utils/utils/schedule.ts

@@ -72,7 +72,6 @@ export const debounce = <T extends (...args: unknown[]) => void>(
         fn(...latestArgs);
         if (removeScheduler) {
           removeScheduler();
-          removeScheduler = null;
         }
       }
     },
@@ -81,7 +80,6 @@ export const debounce = <T extends (...args: unknown[]) => void>(
   const cancel = () => {
     if (isScheduled && removeScheduler) {
       removeScheduler();
-      removeScheduler = null;
     }
     isScheduled = false;
     frameCounter = 0;