Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify: Adds more mentions of __ as reserved by introspection system. #244

Merged
merged 1 commit into from
Dec 9, 2016

Conversation

leebyron
Copy link
Collaborator

The spec chapter on introspection mentions that type artifacts must not be named with "__" since it is reserved. This clarification repeats this information closer to the spec on type system itself along with the rules for determining if object/interface types are valid.

The spec chapter on introspection mentions that type artifacts must not be named with "__" since it is reserved. This clarification repeats this information closer to the spec on type system itself along with the rules for determining if object/interface types are valid.
@stubailo
Copy link
Contributor

Does this exclude the possibility of using __id for IDs, which are not strictly introspection, or will that involve changing this language?

@leebyron
Copy link
Collaborator Author

leebyron commented Nov 22, 2016

Certainly if ids end up both using __ and not being part of the introspection system then the existing language would need to change.

I'd hope we can avoid that outcome though.

So if ids are not defined in the schema and are accessed as meta-fields, they should use __, however if ids are defined in the schema (not a metafield) then they should not use __.

@leebyron leebyron merged commit e1dd452 into master Dec 9, 2016
@leebyron leebyron deleted the clarify-prefix branch December 9, 2016 23:31
IvanGoncharov pushed a commit to IvanGoncharov/graphql that referenced this pull request Jun 17, 2017
…em. (graphql#244)

The spec chapter on introspection mentions that type artifacts must not be named with "__" since it is reserved. This clarification repeats this information closer to the spec on type system itself along with the rules for determining if object/interface types are valid.
saerdnaer added a commit to saerdnaer/graphql-tools that referenced this pull request Apr 6, 2021
graphql "__fake" must not begin with "__", which is reserved by GraphQL introspection.

c.f. graphql/graphql-spec#244
saerdnaer added a commit to saerdnaer/graphql-tools that referenced this pull request Apr 6, 2021
graphql "__fake" must not begin with "__", which is reserved by GraphQL introspection.

c.f. graphql/graphql-spec#244
yaacovCR pushed a commit to ardatan/graphql-tools that referenced this pull request Apr 12, 2021
* fix error as __ is reserved for introspection

graphql "__fake" must not begin with "__", which is reserved by GraphQL introspection.

c.f. graphql/graphql-spec#244

* run yarn changset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants